Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last opened panel when selecting sidepanel button in toolbar #16822

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 24, 2023

Resolves brave/brave-browser#25229

sidebar.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Select the side panel button. (notice it opens reading list panel)
  2. Select the bookmarks panel. And close side panel button
  3. Open side panel button and notice it opens reading list panel. Expected to open bookmarks panel again.

@spylogsster spylogsster requested a review from petemill January 24, 2023 09:53
@spylogsster spylogsster self-assigned this Jan 24, 2023
@spylogsster spylogsster requested a review from a team as a code owner January 24, 2023 09:53
@spylogsster spylogsster requested a review from bsclifton January 24, 2023 09:53
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spylogsster spylogsster merged commit 288a2d8 into master Jan 24, 2023
@spylogsster spylogsster deleted the brave-25229 branch January 24, 2023 22:56
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use last opened panel when selecting sidepanel button in toolbar
3 participants