-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNSLink redirects to unreachable url #25281
Comments
To be clear, there is no DNSLink record for either the unstoppable domains gateway or pin.ski. $ dig +short txt _dnslink.unstoppabledomains.mypinata.cloud
<empty response> So the question is, what is triggering Brave to check for a DNSLink, and why is it requiring that to resolve instead of loading the domain normally? Cloudflare does set |
It is not a bug per se, everything works as expected (IPFS resource identified by a CID is detected, and redirected to local gateway), but the UX is confusing when DNSLink is missing and website is mis-configured like this. I think this is the same problem as one described in ipfs/ipfs-companion#1052 – I proposed fix there where we only redirect URLS that follow Public Gateway convention. Update: I think there is an easier fix: if DNSLink redirect is enabled, Brave should not redirect to |
Resolves brave/brave-browser#25281 Autoredirect to dnslink only if url has _dnslink DNS record. _dnslink has priority over x-ipfs-path content. When there is only x-ipfs-path header then translate url to https://gateway/<x-ipfs-path-content> instead of ipns://original_url
Verified
|
Brave | 1.46.24 Chromium: 106.0.5249.65 (Official Build) nightly (x86_64) |
---|---|
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580} |
OS | macOS Version 11.7 (Build 20G817) |
Case One
- Gateway
Steps:
- installed
1.46.24
- launched Brave
- opened
brave://settings/ipfs
- set
Method to resolve IPFS resources
toGateway
- toggled
Automatically redirect to IPFS pages via DNSLink when possible
toEnabled
- loaded
https://pin.ski/3TNzYjz
- confirmed
https://unstoppabledomains.mypinata.cloud/ipfs/QmTZ4vvV926DN2HwZpd8djLyovFptqk3Xbct71YwJxt28A
loaded, with anIPFS
button in the URL bar - clicked on
IPFS
- confirmed
https://bafybeicnpdfiiozubqar2plzkqvfuygrmm6n7y4zqi4efzppkdycrxrzzm.ipfs.dweb.link/
loaded
brave://settings/ipfs |
initial load | IPFS link |
---|---|---|
Case Two
- Brave local IPFS node
Steps:
- installed
1.46.24
- launched Brave
- opened
brave://settings/ipfs
- set
Method to resolve IPFS resources
toBrave local IPFS node
- toggled
Automatically redirect to IPFS pages via DNSLink when possible
toEnabled
- loaded
https://pin.ski/3TNzYjz
- clicked on
IPFS
in the URL bar - confirmed
http://bafybeicnpdfiiozubqar2plzkqvfuygrmm6n7y4zqi4efzppkdycrxrzzm.ipfs.localhost:48081/
loaded
brave://settings/ipfs |
initial load | IPFS link |
---|---|---|
https://pin.ski/3TNzYjz fails to load because of DNSLink redirect.
There is DNS record for the url, but nodes fail to resolve it.
Steps to Reproduce
Actual result:
ipfs resolve -r /ipns/unstoppabledomains.mypinata.cloud/ipfs/QmPFY3HuzddkKBuZUJ5gQ2REoKQSpECk84nmzs1594suir/: could not resolve name: "unstoppabledomains.mypinata.cloud" is missing a DNSLink record (https://docs.ipfs.io/concepts/dnslink/)
Expected result:
Site opens
Reproduces how often:
100%
Brave version (brave://version info)
1.45
Version/Channel Information:
The text was updated successfully, but these errors were encountered: