Switching chains with uppercase chain ID hex does not work

[yrliou]

Description

Try to switch to Avalanche network via wallet_switchEthereumChain API fails when chain_id param is 0xA86A, and only works if it is passed as 0xa86a.

Steps to Reproduce

Problem 1:

1. Open devtool and run window.ethereum.request({method:'wallet_switchEthereumChain', params: [{chainId: '0xA86A'}]})

Problem 2:

1. Go to brave://settings/wallet/networks and edit the chain ID to be 0xa86A instead of 0xa86a. Save.

Actual result:

Problem 1:

And only window.ethereum.request({method:'wallet_switchEthereumChain', params: [{chainId: '0xa86a'}]}) works.

Problem 2:

Gives an error like this: "Request for method 'eth_chainId' on https://api.avax.network/ext/bc/C/rpc failed"

Expected result:

Problem 1:

Wallet panel should prompt user the request for switching to Avalanche network.

Problem 2:

It should save with no errors.

Reproduces how often:

Always

Desktop Brave version:

Android Device details:

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[srirambv]

Verification passed on the following devices running 1.46.70 x64 beta build

• Verified steps from issue description
• Verified running window.ethereum.request({method:'wallet_switchEthereumChain', params: [{chainId: '0xA86A'}]}) prompts to switch network
• Verified able to approve or cancel the network switch request

Oppo Reno 5 (Android 12)	Samsung Tab A (Android 10)

[srirambv]

Verification passed on

Brave	1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision	a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS	Linux

• Verified steps from issue description
• Verified running window.ethereum.request({method:'wallet_switchEthereumChain', params: [{chainId: '0xA86A'}]}) prompts to switch network
• Verified able to approve or cancel the network switch request
• Verified able to save changes to network without any errors

25707.mp4

---

Verification passed on

Brave	1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision	a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS	Windows 11 Version 22H2 (Build 22621.674)

• Verified steps from issue description
• Verified running window.ethereum.request({method:'wallet_switchEthereumChain', params: [{chainId: '0xA86A'}]}) prompts to switch network
• Verified able to approve or cancel the network switch request
• Verified able to save changes to network without any errors

25707.mp4

---

Verification passed on

Brave	1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision	a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS	macOS Version 13.0 (Build 22A380)

• Verified steps from issue description
• Verified running window.ethereum.request({method:'wallet_switchEthereumChain', params: [{chainId: '0xA86A'}]}) prompts to switch network
• Verified able to approve or cancel the network switch request
• Verified able to save changes to network without any errors

25707.mov