-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave News Customize 2.0 UI #25801
Comments
Added a test plan |
Verification
|
Brave | 1.46.103 Chromium: 107.0.5304.110 (Official Build) beta (x86_64) |
---|---|
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202} |
OS | macOS Version 11.7.1 (Build 20G918) |
&
Brave | 1.46.80 Chromium: 107.0.5304.68 (Official Build) beta (x86_64) |
---|---|
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991} |
OS | macOS Version 11.7.1 (Build 20G918) |
Enable Brave News v2, method 1 - PASSED
- installed
1.46.80
- launched Brave
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- opened a new-tab page
- scroll down
- click on
Show Brave News
- clicked on
Customize
- confirmed I got the v2 UI
Enable Brave News v2, method 2 - PASSED
- installed
1.46.102
- launched Brave
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- opened a new-tab page
- clicked
Customize
- clicked on
Brave News
- confirmed I got the
Turn on Brave News
dialog and button - clicked on
Turn on Brave News
- confirmed I got the rest of the v2 UI
example | example |
---|---|
Disable and re-enable Brave News - PASSED
With Brave News v2 enabled:
- open a new-tab page
- click on
Customize
- click on
Brave News
- toggle
Brave News
toOff
/Disabled
at the top of the dialog - confirm you see
Turn on Brave News, and never miss a story
, with aTurn on Brave News
button, below - click on
Turn on Brave News
- confirm the full UI (with feeds in-tact, if you had them) re-appear
Brave News, enabled |
Brave News, disabled |
Brave News, re-enabled |
---|---|---|
< Back to Dashboard
link - PASSED
With Brave News v2 enabled:
- open a new-tab page
- click on
Customize
- click on
Brave News
- click on
< Back to Dashboard
- confirmed clicking
< Back to Dashboard
took me to theCustomize Dashboard
dialog
example | example |
---|---|
Follow sources - PASSED
Discover sources - PASSED
- open a new-tab page
- click on
Customize
- click on
Brave News
- click on
Turn on Brave News
- click the
Follow
button onWired
- confirm it appears under the
Following
heading - open a new-tab page
- confirm you get
Wired
articles
step 5 | step 6 | step 8 |
---|---|---|
Logged:
Direct sources - PASSED
- opened a new-tab page
- clicked on
Customize
- clicked on
Brave News
- clicked on
Turn on Brave News
- entered
https://abcnews.go.com/abcnews/usheadlines
into theDiscover
search textfield - under
Sources
, clicked onGet feeds from https://abcnews.go.com/abcnews/usheadlines
- confirmed
ABC News: US
source appears - clicked on
Follow
- confirmed
ABC News: US
appears underFollowing
- closed the dialog
- clicked on
Load new content
- confirmed I saw articles from
ABC News: US
Confirmed I saw articles from ABC News: US
in the content feed
step 5 | step 6 | step 7 | step 12 |
---|---|---|---|
Logged:
Unfollow sources - FAILED(*)
(with a source or two already followed; mine is the American Psychological Association
)
- open a new-tab page
- click
Customize
- hover to the right of your source(s), in the
Following
column - choose
Unfollow
- reload your Brave News feed, click
Reload new content
or open a new-tab page - scroll through and confirm the source(s) have been removed -
American Psychological Association
Could not confirm; will verify in #26303
example | example | example | example | example |
---|---|---|---|---|
Follow channel - PASSED
- open a new-tab page
- clicked on
Customize
- under
Channels
, click onFollow
inCars
- click the
X
to close the dialog - scroll Brave News
- click on
Load new content
- confirmed the following articles sources appeared:
- The Drive
- Car and Driver
Customize dialog |
Brave News feed |
---|---|
Unfollow channel - FAILED(*)
- clicked on
Customize
- hovered to the right of
Top Sources
and choseUnfollow
- confirmed I was no longer subscribed to
Top Sources
, underFollowing
- hovered to the right of
Cars
and choseUnfollow
(also testedUnfollow
inside theCars
feed item - confirmed I was no longer subscribed to
Cars
, underFollowing
- clicked on the
X
to dismiss the dialog - reloaded my Brave News feed/clicked
Reload new content
when the bubble appeared - examined the Brave News feed for articles from
Car and Driver
andThe Drive
(*) Could not confirm; will verify in #26303
step 2 | steps 3-4 | step 5 | step 7 | step 8 |
---|---|---|---|---|
Search - PASSED
Sub-string searches - PASSED
- opened a new-tab page
- clicked
Customize
- clicked
Brave News
- searched for the following:
fan |
fanbyte |
nby |
byte |
物件ファン |
件フ |
---|---|---|---|---|---|
Confirmed I could search for leading, main, and trailing parts of the search terms, and find appropriate results
RSS-feed discovery, single feed - PASSED
- opened a new-tab page
- clicked on
Customize
- clicked on
Brave News
- entered
https://www.express.co.uk/news
into the search textfield beneathDiscover
- clicked on the
Get feeds from https://www.express.co.uk
button - confirmed I saw a
Daily Express :: News Feed
source - hovered over it and clicked on
Follow
- confirmed it appeared under `Following
- exited the dialog
- scrolled Brave News
- looked for a Daily Express article
Confirmed I saw Daily Express :: News Feed
articles
example | example | example | example |
---|---|---|---|
RSS-feed discovery, multiple feeds - PASSED
- open a new-tab page
- click on
Customize
- click on
Brave News
- entered
https://www.pravda.ru/
into the search textfield beneathDiscover
- clicked on the
Get feeds from https://www.pravda.ru/
button - confirmed I saw 3
Daily Express :: News Feed
sources:
- Правда.Ру
- Правда.Ру - Новости
- Правда.Ру - Статьи
- clicked
Follow
on all of them - confirmed they appeared under
Following
- exited the dialog
- scrolled Brave News
Confirmed I saw articles from all 3 feed sources, from above
search |
Following |
Правда.Ру |
Правда.Ру - Новости |
Правда.Ру - Статьи |
---|---|---|---|---|
Logged:
NOTE:
- Bugs and followups mentioned here -- even for failing tests -- will be retested in their respective issues, and testing itself will be ongoing (with VPN as the priority, still)
- Windows and Linux will also be tested
@brave/qa-team some of the issues I've already seen and filed on are likely due to https://bravesoftware.slack.com/archives/CU56GUJ1H/p1666975874847419. I've covered some good ground, though definitely need to test channels + subscriptions more. I'm waiting until the push of the backend-server changes from above are live in production, before finishing/retesting. There's also a pending new locale format change, in brave/brave-core#15681 ( |
Verification
Enable Brave News (v2)Case 1: Enable Brave News (v2) via Brave news opt-in in the new-tab page-
|
step 4 | step 8 | step 10-11 |
---|---|---|
Case 2: Enable Brave News (v2) via clicking Customize button in the new-tab page- PASSED
- new profile
- launched Brave
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- opened a new-tab page
- click
Customize
- click
Brave News
in theCustomize Dashboard
- click
Turn on
Brave News` - confirmed new Brave News (v2) UI displayed
Brave News
button is enabled
step 4 | step 8 | step10 | step 10-11 |
---|---|---|---|
Case 3: Back to Dashboard link via clicking Customize button - PASSED
- Continue from Case 2:
- open a new-tab page
- clicked on
Customize
- click
Brave News
in theCustomize Dashboard
- click
Turn on
Brave News`
- click on
< Back to Dashboard
- returned to
Customize Dashboard
screen
step 2 | step 3 |
---|---|
Case 4: Customize Brave News dialog UI - Appearance & UI elements- PASSED
- new profile
- launched Brave
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- opened a new-tab page
- click
Customize
- click
Brave News
in theCustomize Dashboard
- click
Turn on
Brave News` - confirmed new Brave News (v2) UI displayed
Brave News
button is enabled by default- click
Follow
onThe New York Times
&CNN World News
in thePopular
category - click
X
to close the modal - click
Brave News
in theCustomize Dashboard
Suggestions
category displayed based on earlier selections- Click
View all
forPopular
andSuggestions
categories to view all sources - Click
Back
to view Brave news (v2) UI modal includingChannels
- toggle
OFF
Brave News
to turn off the news feed
step 9 | step 10 | step 12 | step15 | step 16 | step 18a | step 18b |
---|---|---|---|---|---|---|
Dark mode
example | example |
---|---|
Light mode
example | example |
---|---|
Follow/Unfollow Sources
Case 5: Follow sources - Single Source PASSED
Discover sources
- new profile
- enabled brave news v2 via
brave://flags/#brave-news-v2
- opened a new-tab page
- clicked on
Show Brave News
- confirmed
Newsweek
article is not available - clicked
Customize
- searched for
Newsweek
and clickFollow
button - confirmed it appears under the
Following
heading - opened a new-tab page
- confirmed
Newsweek
articles displayed
step 2 | step 5 | step 7 | step 10 |
---|---|---|---|
Case 6: Follow sources - Multiple Sources PASSED
Discover sources
- new profile
- enabled brave news v2 via
brave://flags/#brave-news-v2
- opened a new-tab page
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
button - searched for
Time
, NPR,Conde Nast Traveler
Delishand clicked
Follow` button - confirmed it appears under the
Following
heading in the left column - opened a new-tab page
- confirmed articles for
Time
, NPR,Conde Nast Traveler
Delish` shown in the Brave news feed
step 8 | NPR | Time | Conde Nast | Delish |
---|---|---|---|---|
Case 7: Unfollow sources - PASSED
- continue from Case 6
- opened a new-tab page
- clicked
Customize
- multiple sources shown in the
Following
pane in the left column (NPR
,Time
,Conde Nast
,Delish
- articles for
NPR
,Time
,Conde Nast
&Delish
shown in the Brave news feed
- hovered to the right of your source(s),(
NPR
&Delish
) in theFollowing
column - clicked
Unfollow
- clicked the
X
to close the dialog - clicked
Load new content
(or reload your Brave News feed, or open a new-tab page) - scrolled through and confirm the source(s) have been removed -
NPR
&Delish
Confirmed NPR
& Delish
resources have been removed from Following
pane and Brave news feed.
step 1 | step 1 sources | step 2-3 | step 5 | step 6 |
---|---|---|---|---|
Follow/Unfollow Channels
Case 8: Follow Channel - PASSED
- new profile
- enabled brave news v2 via
brave://flags/#brave-news-v2
- opened a new-tab page
- clicked
Show Brave News
- clicked
Customize
- under
Channels
, clicked onFollow
inFood
- Unfollowed
Top Sources
- clicked the
X
to close the dialog - clicked on
Load new content
- scrolledl thru the feed
- confirmed the following articles appeared:
- Delish
- Serious Eats
step 2 | step 6 | step 7 | step 9 | step 11 |
---|---|---|---|---|
Case 9: Unfollow channel - PASSED
- continue from Case 8
- open a new-tab page
- clicked
Customize
Food
channel is available in theFollowing
pane
- clicked
Follow
to follow couple of more channels -Culture
&Travel
- hovered to the right of
Food
, &Travel
and clickUnfollow
- confirmed
Food
&Travel
were no longer subscribed underFollowing
- clicked on the
X
to dismiss the dialog - clicked
Load new content
indicator to reload the content forCulture
channel (wait for couple of secs for the indicator) - verified the Brave News feed for articles from
Culture
step 1 | step 2 | step 3a | step 3b | step 4-6 | step 6 |
---|---|---|---|---|---|
Search
Case 10: Search bar - Sub-string searches - PASSED
- new profile
- opened a new-tab page
- clicked
Customize
- clicked
Brave News
- click
Turn on Brave News
- searched for the following:
Blo |
com |
NBC |
日本版 |
El Español |
---|---|---|---|---|
Case 11: Search via a site's url - PASSED
- new profile
- enable brave news v2 via
brave://flags/#brave-news-v2
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
- beneath Discover, entered https://blog.mozilla.org/feed/ in the search bar
- clicked on Get feeds from https://blog.mozilla.org/feed/
- clicked
Follow
onThe Mozilla Blog
source to appear onFollowing
pane
step 6 | step 7 | step 8 |
---|---|---|
Case 12: Search via a site's name - PASSED
- new profile
- enable Brave news v2 via
brave://flags/#brave-news-v2
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
- beneath Discover, enter
wired
in the search bar
7 confirmed all 3 sources returned - clicked
Follow
on all three sources and both shown on theFollowing
pane - open new-tab page
step 7 | wired | wired-UK | wired-jp |
---|---|---|---|
Case 13: Brave News (v2) for Multiple profiles - PASSED
Profile 1:
- new profile
- enabled Brave news v2 via
brave://flags/#brave-news-v2
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
- Brave news V2 modal and feed displayed as expected
step 6a | step 6b |
---|---|
Profile 2:
- click Hamburger menu>>create a new profile>>profile 2
- scroll thru new-tab page
- clicked
Show Brave News
- clicked
Customize
- Brave News (v2) modal displayed as expected
- click
Follow
forThe New York Times
- clicked
X
to close the dialog - News York Times article links displayed on the Brave News feed as expected
step 4 | step 5 | step 8 |
---|---|---|
Case 14: Upgrade - Brave News (v2) - PASSED
Before Upgrade :
- Install 1.45.123
- launched Brave
- created multiple profiles (i.e. Profile 1 & Profile 2)
- enabled Brave News on Profile 1
- do not enable Brave News on Profile 2
- closed the browser
- renamed to Beta
Profile 1 | Profile 2 |
---|---|
After Upgrade: Profile 1:
- open brave://flags
- enabled
#brave-news-v2
flag - clicked
Customize
- clicked
Brave News
in theCustomize Dashboard
- Brave News (v2) modal displayed as expected
- followed
TechCrunch
source - clicked
X
on both modals and clicked new-tab page - Brave news feed displayed as expected including articles for
TechCrunch
step 2 | step 5 | step 8 |
---|---|---|
After Upgrade: Profile 2:
- clicked
Show Brave News
- clicked
Customize
- Brave News (v2) modal displayed as expected
- click Follow on
Le Monde
- clicked
X
to close the dialog - clicked
Load new content
indicator - Brave news feed displayed as expected including articles for
LeMonde
step 1 | step 3 | step 6 | step 7 |
---|---|---|---|
Filed:
Unsetting @brave/qa-team testing can and should resume; thanks! re: #25801 (comment) |
Verification passed on
Enable Brave News (v2)Enable Brave News v2 in Polish locale-
|
Blo |
com |
NBC |
日本版 |
El Español |
---|---|---|---|---|
Case 11: Search via a site's url - PASSED
- new profile
- enable brave news v2 via
brave://flags/#brave-news-v2
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
- beneath Discover, entered https://blog.mozilla.org/feed/ in the search bar
- clicked on Get feeds from https://blog.mozilla.org/feed/
- clicked
Follow
onThe Mozilla Blog
source to appear onFollowing
pane
Case 12: Search via a site's name - PASSED
- new profile
- enable Brave news v2 via
brave://flags/#brave-news-v2
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
- beneath Discover, enter
wired
in the search bar
7 confirmed all 3 sources returned - clicked
Follow
on all three sources and both shown on theFollowing
pane - open new-tab page
Case 13: Brave News (v2) for Multiple profiles - PASSED
Profile 1:
- new profile
- enabled Brave news v2 via
brave://flags/#brave-news-v2
- clicked
Customize
- clicked
Brave News
- clicked
Turn on Brave News
- Brave news V2 modal and feed displayed as expected
Profile 2:
- click Hamburger menu>>create a new profile>>profile 2
- scroll thru new-tab page
- clicked
Show Brave News
- clicked
Customize
- Brave News (v2) modal displayed as expected
- click
Follow
forFox news
- clicked
X
to close the dialog - article links displayed on the Brave News feed as expected
Case 14: Upgrade - Brave News (v2) - PASSED
Before Upgrade :
- Install 1.45.x
- launched Brave
- created multiple profiles (i.e. Profile 1 & Profile 2)
- enabled Brave News on Profile 1
- do not enable Brave News on Profile 2
- closed the browser
- renamed to Beta
Profile 1 | Profile 2 |
---|---|
After Upgrade: Profile 1:
- open brave://flags
- enabled
#brave-news-v2
flag - clicked
Customize
- clicked
Brave News
in theCustomize Dashboard
- Brave News (v2) modal displayed as expected
- followed
TechCrunch
source - clicked
X
on both modals and clicked new-tab page - Brave news feed displayed as expected including articles for
TechCrunch
After Upgrade: Profile 2:
- clicked
Show Brave News
- clicked
Customize
- Brave News (v2) modal displayed as expected
- click Follow on
Le Monde
- clicked
X
to close the dialog - clicked
Load new content
indicator - Brave news feed displayed as expected including articles for
LeMonde
Now we have a UI & implementation spec for the Brave News API we should implement it behind a flag.
https://www.figma.com/file/SDcE22eeUsV2uc4dy3NwaC/Onboarding?node-id=195%3A66414
@petemill
Test Plan:
Can enable a source
Can unfollow a source
Can enable a channel
Search
Search via a site's url
The expected source is displayed
Search via a site's name
The expected source is displayed
The text was updated successfully, but these errors were encountered: