Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set focus to transaction when Transaction confirmed notification is clicked #25841

Closed
srirambv opened this issue Oct 6, 2022 · 1 comment · Fixed by brave/brave-core#15375
Closed

Set focus to transaction when Transaction confirmed notification is clicked #25841

srirambv opened this issue Oct 6, 2022 · 1 comment · Fixed by brave/brave-core#15375
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include suggestion
Milestone
1.46.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2022

Description

Set focus to transaction when Transaction confirmed notification is clicked

Steps to Reproduce

  1. Submit a transaction
  2. Wait for notification to show up
  3. Click on notification, opens new tab and loads but doesn't focus on the completed transaction

Actual result:

Transaction is not focused when notification is clicked

Expected result:

Set focus to transaction when Transaction confirmed notification is clicked

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel
@srirambv srirambv added this to Web3 Oct 6, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Oct 6, 2022
@Douglashdaniel Douglashdaniel self-assigned this Oct 6, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Oct 6, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Oct 6, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Oct 6, 2022
Repository owner moved this from In Review to Done in Web3 Oct 6, 2022
@Douglashdaniel Douglashdaniel added this to the 1.46.x - Nightly milestone Oct 17, 2022
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from issue description & brave/brave-core#15375
  • Verified focus is set to transaction when notification is clicked
25841.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description & brave/brave-core#15375
  • Verified focus is set to transaction when notification is clicked
25841.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description & brave/brave-core#15375
  • Verified focus is set to transaction when notification is clicked
25841.mov

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include suggestion
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Transaction Scroll Into View brave/brave-core
2 participants
@srirambv @Douglashdaniel