Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show token prices within Fund-Wallet screen #25861

Closed
josheleonard opened this issue Oct 7, 2022 · 1 comment · Fixed by brave/brave-core#15393
Closed

Show token prices within Fund-Wallet screen #25861

josheleonard opened this issue Oct 7, 2022 · 1 comment · Fixed by brave/brave-core#15393
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@josheleonard
Copy link

Description

Show the current price of the assets available for purchase within the fund-wallet screen.

Actual result:

Prices are not shown

Expected result:

Show the price of the asset/token based on the selected fiat currency.

Reproduces how often:

Easy
@josheleonard josheleonard self-assigned this Oct 7, 2022
@josheleonard josheleonard added this to Web3 Oct 7, 2022
@josheleonard josheleonard added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 7, 2022
@josheleonard josheleonard mentioned this issue Oct 7, 2022
Merged
25 tasks
@josheleonard josheleonard moved this to Done in Web3 Oct 12, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 12, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 13, 2022
@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2022

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
@rebron rebron changed the title Feature request: Show token prices within Fund-Wallet screen Show token prices within Fund-Wallet screen Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat: show token prices in fund wallet screen brave/brave-core
5 participants
@rebron @srirambv @LaurenWags @josheleonard @brave-builds