Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filecoin to onboarding onramp assets for purchase #25660

Closed
josheleonard opened this issue Sep 27, 2022 · 1 comment · Fixed by brave/brave-core#15250
Closed

Add Filecoin to onboarding onramp assets for purchase #25660

josheleonard opened this issue Sep 27, 2022 · 1 comment · Fixed by brave/brave-core#15250
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@josheleonard
Copy link

josheleonard commented Sep 27, 2022 •
edited
Loading

Description

Filecoin was not show as a purchasable currency during onboarding.

Steps to Reproduce

  1. Create a wallet
  2. Navigate to brave://wallet/crypto/fund-wallet
  3. Attempt to purchase FIL

Actual result:

FIL is not shown in the list

Expected result:

FIL is show in the list or purchasable assets

Reproduces how often:

Easy

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@josheleonard josheleonard self-assigned this Sep 27, 2022
@josheleonard josheleonard mentioned this issue Sep 27, 2022
Merged
25 tasks
@jamesmudgett jamesmudgett moved this to In Review in Web3 Sep 30, 2022
Repository owner moved this from In Review to Done in Web3 Oct 3, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 3, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 13, 2022
@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2022

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from issue description and brave/brave-core#15250
  • Verified Filecoin is listed and able to purche via onramp provider
25660.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description and brave/brave-core#15250
  • Verified Filecoin is listed and able to purche via onramp provider
25660.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description and brave/brave-core#15250
  • Verified Filecoin is listed and able to purche via onramp provider
25660.mov

@srirambv srirambv mentioned this issue Nov 1, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

fix: add Filecoin to supported onboarding onramps brave/brave-core
4 participants
@srirambv @LaurenWags @josheleonard @brave-builds