Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Filecoin to supported onboarding onramps #15250

Merged

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Sep 27, 2022

Resolves brave/brave-browser#25660

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2022-09-27.at.4.33.40.PM.mov

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 27, 2022
@josheleonard josheleonard force-pushed the fix-add-filecoin-to-onboarding-onramp-networks branch from 555fde0 to 7dd943e Compare September 27, 2022 22:47
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-add-filecoin-to-onboarding-onramp-networks branch from 7dd943e to 9690e93 Compare September 28, 2022 17:33
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-add-filecoin-to-onboarding-onramp-networks branch from 9690e93 to ea7ee75 Compare September 29, 2022 23:25
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-add-filecoin-to-onboarding-onramp-networks branch from ea7ee75 to 273a24a Compare September 30, 2022 14:40
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-add-filecoin-to-onboarding-onramp-networks branch from 273a24a to 674f13a Compare September 30, 2022 19:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-add-filecoin-to-onboarding-onramp-networks branch from 674f13a to 949cb4e Compare October 3, 2022 15:49
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard merged commit b242e7c into master Oct 3, 2022
@josheleonard josheleonard deleted the fix-add-filecoin-to-onboarding-onramp-networks branch October 3, 2022 20:20
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Filecoin to onboarding onramp assets for purchase
3 participants