Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup doesn't close after gateway url change #26104

Closed
cypt4 opened this issue Oct 18, 2022 · 2 comments · Fixed by brave/brave-core#15705
Closed

Popup doesn't close after gateway url change #26104

cypt4 opened this issue Oct 18, 2022 · 2 comments · Fixed by brave/brave-core#15705
Assignees
@cypt4
Labels
feature/settings feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@cypt4
Copy link

cypt4 commented Oct 18, 2022 •
edited
Loading

Description

After clicking the "Submit" button popup doesn't close
image
@cypt4 cypt4 self-assigned this Oct 18, 2022
@cypt4 cypt4 added this to Web3 Oct 18, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 21, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 21, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Oct 28, 2022
@cypt4
Close gateway url change popup after click submit
1b7c413 
Resolves brave/brave-browser#26104
@cypt4 cypt4 mentioned this issue Oct 28, 2022
Merged
25 tasks
Repository owner moved this from Backlog to Done in Web3 Nov 13, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 13, 2022
@stephendonner
Copy link

This was/is a duplicate of #21479 - thanks for fixing!

@stephendonner stephendonner mentioned this issue Dec 11, 2022
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Linux
  • Verified steps from issue description
  • Verified able to close the popup for both public gateway and NFT gateway settings
26104.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from issue description
  • Verified able to close the popup for both public gateway and NFT gateway settings
26104.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (arm64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description
  • Verified able to close the popup for both public gateway and NFT gateway settings
26104.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/settings feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Close gateway url change popup after click submit brave/brave-core
5 participants
@stephendonner @rebron @srirambv @brave-builds @cypt4