Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shields button background #26180

Closed
samartnik opened this issue Oct 21, 2022 · 1 comment · Fixed by brave/brave-core#15601
Closed

Fix shields button background #26180

samartnik opened this issue Oct 21, 2022 · 1 comment · Fixed by brave/brave-core#15601
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@samartnik
Copy link
Contributor

samartnik commented Oct 21, 2022

Description

This is follow up for #26155

Screenshot_20221021-120211

Steps to reproduce

  1. Goto wikipedia.com or facebook.com
  2. Shields button background is wrong (see picture)

Actual result

Shields button background is wrong

Expected result

Shields button background is right

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Oct 21, 2022
@samartnik samartnik self-assigned this Oct 21, 2022
@samartnik samartnik added this to the 1.47.x - Nightly milestone Oct 21, 2022
@SergeyZhukovsky SergeyZhukovsky added QA/Yes release-notes/exclude priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 21, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.47.135 Chromium: 108.0.5359.128 (Official Build) beta (32-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/TQ1A.221205.011

Light Theme

Example Example
Screenshot_20221219-170035 Screenshot_20221219-170121

Dark Theme

Example Example
Screenshot_20221219-170053 Screenshot_20221219-170058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants