Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News] Remove code branch for migration to new locales format when 1.46 goes stable #26307

Closed
fallaciousreasoning opened this issue Oct 26, 2022 · 0 comments · Fixed by brave/brave-core#17046
Closed

[Brave News] Remove code branch for migration to new locales format when 1.46 goes stable #26307

fallaciousreasoning opened this issue Oct 26, 2022 · 0 comments · Fixed by brave/brave-core#17046
Labels
feature/brave-news formerly brave-today OS/Desktop QA/No release-notes/exclude
Milestone
1.49.x - Release #3

Comments

@fallaciousreasoning
Copy link

We migrated to a new format for locales and the parser has code for the old format and the new format. Once the new code has been live for a while, we can remove the branch for the old sources format.
@fallaciousreasoning fallaciousreasoning mentioned this issue Oct 27, 2022
Merged
25 tasks
@fallaciousreasoning fallaciousreasoning mentioned this issue Feb 5, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 7, 2023
@kjozwiak kjozwiak mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/brave-news formerly brave-today OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release #3
Development

Successfully merging a pull request may close this issue.

Brave News sometimes picks the wrong language in the Subscribe Button brave/brave-core
2 participants
@fallaciousreasoning @brave-builds