[Uplift] [1.49]: Brave News sometimes picks the incorrect language #17633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#17046) * Fix bug where first source was returned instead of the one in default locale * Update JSON * Add tests * Remove string locale support (it isn't used) * Changes for PR
fallaciousreasoning
requested review from
a team,
bsclifton,
goodov,
iefremov,
simonhong and
bridiver
as code owners
fallaciousreasoning
removed request for
a team,
bridiver,
iefremov,
bsclifton,
goodov and
simonhong
|
Created brave/brave-browser#29159 for the |
kjozwiak
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#28064 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #17046
Resolves brave/brave-browser#28064
Resolves brave/brave-browser#26092
Resolves brave/brave-browser#26307