Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspacing after searching for non-existent feed source seems to "hang" search #26308

Closed
stephendonner opened this issue Oct 26, 2022 · 6 comments · Fixed by brave/brave-core#19036

Comments

@stephendonner
Copy link

Description

Backspacing after searching for non-existent feed source seems to "hang" search

Steps to Reproduce

  1. install 1.47.20
  2. launch Brave
  3. open brave://flags
  4. set brave://flags/#brave-news-v2 to Enabled
  5. open a new-tab page
  6. click on Customize
  7. click on Brave News
  8. click on Turn on Brave News
  9. type https://brave.com
  10. click on the Get feeds from https://brave.com
  11. now, backspace/delete the m
  12. wait...

Actual result:

step 9 step 10 step 11
Screen Shot 2022-10-26 at 4 10 31 PM Screen Shot 2022-10-26 at 4 10 35 PM Screen Shot 2022-10-26 at 4 10 38 PM

Expected result:

Screen Shot 2022-10-26 at 4 12 05 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.20 Chromium: 107.0.5304.68 (Official Build) nightly (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @mattmcalister

@fallaciousreasoning
Copy link

Was this fixed by brave/brave-core#15611 or is it still happening? Just having a play around to try and repro and I'm not having too much success

@stephendonner
Copy link
Author

Was this fixed by brave/brave-core#15611 or is it still happening? Just having a play around to try and repro and I'm not having too much success

Can still easily reproduce this 100% using

Brave 1.47.33 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

@fallaciousreasoning
Copy link

Okay cool, I'll dig into it a bit more

@mattmcalister mattmcalister added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 31, 2023
@mattmcalister
Copy link

Reducing priority on this. Yes, it's odd behavior, but it's very minor. Not closing it yet but not prioritizing it atm.

@fallaciousreasoning
Copy link

fallaciousreasoning commented Jun 26, 2023

Does this still repro in latest Nightly? I had a quick go in 1.55.5 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit) (Linux) and it seemed to be fine.

Scratch that, I was holding it wrong 😆

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.58.78 Chromium: 116.0.5845.51 (Official Build) nightly (x86_64)
Revision ca260d8
OS macOS Version 11.7.9 (Build 20G1426)

Used my steps to reproduce from #26308 (comment).

Confirmed pressing delete / backspace doesn't "hang" the search UI, and it updates dynamically

news-fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants