Description text for Redirect IPFS resources to the configured IPFS gateway could be a little clearer

[stephendonner]

Description

Description text for Redirect IPFS resources to the configured IPFS gateway could be a little clearer

Steps to Reproduce

1. install 1.47.42
2. launch Brave
3. load brave://settings/ipfs
4. read the wall of text under Redirect IPFS resources to the configured IPFS gateway

Actual result:

Requests to IPFS resources, hosted on third-party IPFS gateways will be loaded via selected local or remote gateway. Note: If local node is selected, resource will be requested directly from your computer and cached data may be provided to the IPFS network for some time.

I understand this came from a security review, so I'm not knocking it, we could just make it a little clearer?

Expected result:

It could be slightly better: maybe an article the here or there (e.g. the resource will be requested, and will be loaded via the selected, and maybe a comma for the clause on the end of `hosted on third-party gateways,"

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.47.42 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision	3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS	macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rmcfadden3 @cypt4

[stephendonner]

Cross-reference #26374 and https://github.com/brave/security/issues/1063

[rmcfadden3]

@stephendonner — something like this?

Requests to IPFS resources (hosted on third-party IPFS gateways) will be loaded via a selected local or remote gateway. If a local node is selected, the resource will be requested directly from your computer and cached data may be provided to the IPFS network for some time.

Oh, and do you know if we can give any more specificity around what "…for some time." means in this case?

[stephendonner]

@stephendonner — something like this?

Requests to IPFS resources (hosted on third-party IPFS gateways) will be loaded via a selected local or remote gateway. If a local node is selected, the resource will be requested directly from your computer and cached data may be provided to the IPFS network for some time.

Oh, and do you know if we can give any more specificity around what "…for some time." means in this case?

I do not, but am betting @cypt4 @yrliou @lidel will be able to help suss that out 👍

[lidel]

Cached IPFS blocks are reprovided to the network until they are garbage-collected.
GC can be manually triggered by the user on the brave://ipfs-internals screen, or happen automatically after brave.ipfs.storage_max is reached.

So maybe "for some time" → "until it is garbage-collected"?

[vadimstruts]

The IPFS local node and scheme has been deprecated