Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change description for "Redirect IPFS resources to configured gateway" feature #26374

Closed
cypt4 opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15721
Closed

Change description for "Redirect IPFS resources to configured gateway" feature #26374

cypt4 opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15721
Assignees
@cypt4
Labels
feature/web3/ipfs OS/Desktop QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.47.x - Release

Comments

@cypt4
Copy link

cypt4 commented Oct 28, 2022

According https://github.com/brave/security/issues/1063
@cypt4 cypt4 added this to Web3 Oct 28, 2022
@cypt4 cypt4 mentioned this issue Oct 31, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Oct 31, 2022
@cypt4
Change redirect IPFS resources setting description
a527eee 
Resolves brave/brave-browser#26374
@cypt4 cypt4 moved this to Done in Web3 Nov 2, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 2, 2022
@stephendonner
Copy link

@cypt4 can you please provide a step-by-step testplan for this? Although it says "Change description..." it looks like there are quite a few changes here I should help regression-test?

@stephendonner stephendonner mentioned this issue Nov 4, 2022
Closed
@LaurenWags
Copy link
Member

@cypt4 pinging on #26374 (comment).

cc @kjozwiak @rebron @srirambv

@srirambv
Copy link
Contributor

srirambv commented Jan 4, 2023

Verification passed on

Brave 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
Revision 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS Linux
  • Verified test plan from brave/brave-core#15721
  • Verified text copy is same as mentioned in security#1063 (comment)
  • Verified with setting enabled loading gateway.io/ipfs/bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy redirects to ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy
  • Verified with settings enabled loading bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy.ipfs.gateway.io redirects to ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy
26374.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs OS/Desktop QA Pass-Linux QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Redirect gateway-like urls to ipfs:// brave/brave-core
6 participants
@stephendonner @yrliou @srirambv @LaurenWags @brave-builds @cypt4