Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect gateway-like urls to ipfs:// #15721

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Redirect gateway-like urls to ipfs:// #15721

merged 2 commits into from
Nov 2, 2022

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Oct 31, 2022 •
edited
Loading

Resolves brave/brave-browser#26374

Passed sec review https://github.com/brave/security/issues/1063

For the text change:
image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies arehttps://github.com/brave/security/issues/1063 properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test that this redirects are working with the setting "Redirect IPFS resources to the configured gateway" is enabled:
gateway.io/ipfs/bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy ->
ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy
bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy.ipfs.gateway.io ->
ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfy
Also check that setting description matches https://github.com/brave/security/issues/1063#issuecomment-1294065874

@cypt4 cypt4 requested a review from iefremov October 31, 2022 15:49
@cypt4
Redirect gateway-like urls to ipfs://
c9db9dc 
Resolves brave/brave-browser#21454
Urls in format of https://bafy.ipfs.gateway.io or https://gateway.io/ipfs/bafy
are now redirected to ipfs:// scheme if x-ipfs-path header is received
@cypt4 cypt4 requested review from yrliou and removed request for iefremov October 31, 2022 15:59
@cypt4 cypt4 requested a review from iefremov as a code owner October 31, 2022 16:03
@cypt4 cypt4 changed the title Fix IPFS redirect setting description Redirect gateway-like urls to ipfs:// Oct 31, 2022
@cypt4 cypt4 merged commit 7959057 into master Nov 2, 2022
@cypt4 cypt4 deleted the brave_21454_2 branch November 2, 2022 18:17
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 2, 2022
@srirambv srirambv mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@iefremov iefremov iefremov approved these changes

Assignees

@cypt4 cypt4

Labels
None yet
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.

Change description for "Redirect IPFS resources to configured gateway" feature
3 participants
@cypt4 @iefremov @yrliou