VPN subscriber credential is not refreshed on startup till panel is opened

[simonhong]

Description

Subscriber credential is refreshed during the runtime when when it's expired.
If it's expired while browser isn't used, it's not refreshed on startup till panel is opened

Steps to Reproduce

1. Make purchased state and shutdown
2. Wait till cached credential is expired and relaunch
3. Open vpn panel after some minutes passed

Actual result:

User can see vpn panel has spinning

Expected result:

User could see vpn panel spinning if panel is opened right after startup.
But, could see main panel w/o spinning if opened after some times passed

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[kjozwiak]

The above requires 1.46.103 or higher for 1.46.x verification 👍

[MadhaviSeelam]

Verification PASSED using

Brave | 1.46.129 Chromium: 108.0.5359.48 (Official Build) (64-bit)
-- | --
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | Windows 11 Version 21H2 (Build 22000.1219)

1. installed 1.46.129
2. launched Brave
3. opened brave://flags
4. set brave://flags#brave-vpn to Enabled
5. relaunched Brave
6. loaded account.bravesoftware.com
7. entered username/password from 1PW
8. entered test28-nov28@mailinator.com, clicked Get login link
9. clicked the link in the email
10. clicked Browse plans
11. scrolled down
12. clicked on Buy now for Brave VPN Subscription
13. completed the Stripe purchase flow
14. confirmed I could connect to the VPN
15. closed Brave browser
16. disconnected from the BraveVPN connection in VPN settings in the Windows settings>>Network&internet
17. opened Local State from my user profile
18. edited the value for brave.brave_vpn.subscriber_credential.expiration, from 13312583928000000 to 133125839280000 by deleting the last 2 0 numbers
19. relaunched Brave
20. confirmed able to connect to VPN

step 4	step 10	step 14	step 16	step 17	step 18	step 20

[stephendonner]

Verified PASSED using

Brave	1.46.129 Chromium: 108.0.5359.48 (Official Build) (x86_64)
Revision	18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS	macOS Version 11.7.1 (Build 20G918)

Steps:

1. installed 1.46.129
2. launched Brave
3. opened brave://flags
4. set brave://flags#brave-vpn to Enabled
5. relaunched Brave
6. loaded account.bravesoftware.com
7. entered username/password from 1PW
8. entered test28-nov28@mailinator.com, clicked Get login link
9. clicked the link in the email
10. clicked Browse plans
11. scrolled down
12. clicked on Buy now for Brave VPN Subscription
13. completed the Stripe purchase flow
14. confirmed I could connect to the VPN
15. closed Brave browser
16. disconnected from the BraveVPN connection in VPN settings in the Windows settings>>Network&internet
17. opened Local State from my user profile
18. edited the value for brave.brave_vpn.subscriber_credential.expiration, from 1331420629200000000 to 13314206292000000 by deleting the last 2 0 digits
19. relaunched Brave
20. confirmed able to connect to VPN

example	example	example	example	example	example