Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate SNS into Brave wallet to allow users navigate to .sol domains #26652

Closed
supermassive opened this issue Nov 10, 2022 · 1 comment · Fixed by brave/brave-core#15863
Closed

Integrate SNS into Brave wallet to allow users navigate to .sol domains #26652

supermassive opened this issue Nov 10, 2022 · 1 comment · Fixed by brave/brave-core#15863
Assignees
@supermassive
Labels
feature/web3/ddns feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@supermassive
Copy link

Complete the native resolution of SNS records inside Brave’s browser
github doc: https://github.com/Bonfida/name-resolver
@supermassive supermassive self-assigned this Nov 10, 2022
This was referenced Nov 10, 2022
Merged
Closed
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 18, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 2, 2022
@bbondy bbondy mentioned this issue Dec 13, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Jan 5, 2023

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Linux
  • Verified steps from brave/brave-core#15863
  • Verified navigating to a .sol domain shows interstitial page the first time
  • Verified clicking on Proceed using Coinbase Cloud server auto redirects the page to the correct resolving domain
26652.mp4

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15863
  • Verified navigating to a .sol domain shows interstitial page the first time
  • Verified clicking on Proceed using Coinbase Cloud server auto redirects the page to the correct resolving domain
26652.mp4

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (arm64)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15863
  • Verified navigating to a .sol domain shows interstitial page the first time
  • Verified clicking on Proceed using Coinbase Cloud server auto redirects the page to the correct resolving domain
26652.mov

@StephenHeaps StephenHeaps mentioned this issue Jan 5, 2023
Closed
@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/ddns feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

SNS domain resolving brave/brave-core
4 participants
@supermassive @srirambv @LaurenWags @brave-builds