Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNS domain resolving #15863

Merged
merged 2 commits into from
Nov 18, 2022
Merged

SNS domain resolving #15863

merged 2 commits into from
Nov 18, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Nov 9, 2022 •
edited
Loading

Resolves brave/brave-browser#26652

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Run with --enable-features=BraveWalletSns
Omnibox navigation to to onybose.sol should redirect to https://anirudha.co

@supermassive supermassive requested review from a team and iefremov as code owners November 9, 2022 09:46
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build labels Nov 9, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

supermassive
supermassive commented Nov 10, 2022
View reviewed changes
components/decentralized_dns/content/decentralized_dns_opt_in_page.cc
u"href='https://consensys.net/terms-of-use/' "
u"target='_blank' rel='noopener noreferrer'>",
const std::vector<std::u16string> infura_links = {
u"https://consensys.net/terms-of-use/",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted templates so they need only url params.
Removed noopener noreferrer flags as they are redundant on pages with opaque origin

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

iefremov
iefremov approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser/net/* and chromium_src LGTM

@iefremov
Copy link
Contributor

perhaps it may need a sec review

yrliou
yrliou reviewed Nov 14, 2022
View reviewed changes
components/decentralized_dns/content/BUILD.gn Outdated Show resolved Hide resolved
components/brave_wallet/browser/json_rpc_service.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Show resolved Hide resolved
yrliou
yrliou approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive
Copy link
Collaborator Author

@diracdeltas can we merge this?
It seems there are no major security and privacy issues so we can have it in nightly behind a feature flag. We can address any further findings with 'enable feature by default' PR

@diracdeltas
Copy link
Member

It seems there are no major security and privacy issues so we can have it in nightly behind a feature flag. We can address any further findings with 'enable feature by default' PR

ok to go from security perspective but @ShivanKaul should take a look (he was busy yesterday). Is the plan to put SNS domain resolution ON by default? I thought it was 'Ask'?

@yrliou
Copy link
Member

yrliou commented Nov 17, 2022 •
edited
Loading

It seems there are no major security and privacy issues so we can have it in nightly behind a feature flag. We can address any further findings with 'enable feature by default' PR

ok to go from security perspective but @ShivanKaul should take a look (he was busy yesterday). Is the plan to put SNS domain resolution ON by default? I thought it was 'Ask'?

@diracdeltas I think what @supermassive meant was we will create another PR to actually enable the SNS feature flag by default when security & privacy review issue is closed, currently the feature flag is disable by default. The resolve method pref is default to Ask and will not be changed. https://github.com/brave/brave-core/pull/15863/files#diff-3e5ca225627eb4399a80579331ce512deadf7355a7ec6ffb211bd7edda2de0fbR26-R27

@ShivanKaul
Copy link
Collaborator

If it's disabled behind feature flag I don't oppose merging now.

@diracdeltas
Copy link
Member

ok sgtm to merge then and then open another PR with security review for enabling the feature flag by default

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive merged commit e9da5c8 into master Nov 18, 2022
@supermassive supermassive deleted the sns_domain_resolve branch November 18, 2022 05:23
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 18, 2022
@srirambv srirambv mentioned this pull request Jan 5, 2023
Closed
@yrliou yrliou mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas left review comments

@yrliou yrliou yrliou approved these changes

@iefremov iefremov iefremov approved these changes

Assignees

@supermassive supermassive

Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.

Integrate SNS into Brave wallet to allow users navigate to .sol domains
6 participants
@supermassive @brave-builds @iefremov @diracdeltas @yrliou @ShivanKaul