-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 108.0.5359.40 to Chromium 108.0.5359.48. #26820
Comments
@brave/qa-team - |
Verification
|
Brave | 1.46.123 Chromium: 108.0.5359.48 (Official Build) beta (x86_64) |
---|---|
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854} |
OS | macOS Version 11.7.1 (Build 20G918) |
about:
screenshot
Areas:
Settings UI (multiple changes all over -- needs regression testing) - PASSED
NTP background custom images (adding/removing) - PASSED
Use your own (custom bg image)
- Confirmed that user can select the custom background for NTP
- Confirmed that user can choose the induvidual custom background via NTP
- Confirmed that same custom background is shown on each the NTP when the induvidual gradient background is selected and
Refresh on every new tab
switch is OFF - Confirmed that different custom bg images shown on each NTP when
Refresh on every new tab
switch is ON - Confirmed that on each custom background color, the NTP stats (Cards, clock, Top sites, Brave stats etc) are shown clearly/correctly
- Confirmed that selected custom background retained on the NTP after the browser restart
- Confirmed that Check mark is shown on the selected custom background
- Confirmed that selected custom background retained across all the tabs and windows in Regular window
- Confirmed that selected custom background retained only for the Profile 1
- Confirmed that user has provision to select the different custom background colors for multiple profiles
- Confirmed that selecting custom background doesn't impact the NTP SI show on NTP
- Confirmed that NTP SI are shown in the order 2, 4, 8 tabs and confirmed custom background is checked the background images grid
Example | Example | Example | Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|---|---|---|
Regression on NTP
- Ensured Tops sites can be edit/delete via NTP
- Ensured that NTP stats can be hidden/shown
- Ensured that a site can be added via NTP
- Ensured NTP Widget cards can be added/removed
- Ensured NTP SI works as expected
- Ensured that click on settings (bookmarks, history, settings and brave talk) shortcuts works as expected
- Ensured that the solid/gradient background images and Brave background works as expected
Example | Example | Example | Example | Example |
---|---|---|---|---|
Sidebar (adding/removing items) - PASSED
Side panel:
- Confirmed that sidebar is shown by default in the nightly channel
- Confirmed that Reading list icon is added to the sidebar menu
- Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
- Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
- Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
- Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
- Confirmed that reading list icon is shown in the URL bar, next to wallet icon
- Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
- Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
- Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as
Add to current tab
option is not getting activated #24930 - Confirmed that sites can be segregated to Read and Unread list
- Confirmed that sites can be deleted from the reading list
example | example | example |
---|---|---|
Sidebar:
- Confirmed sites can be added to sidebar by clicking on + add to sidebar option
- Confirmed added sites can be edited via Edit option
- Confirmed that added sites can be removed via Remove option
- Confirmed that sidebar settings can be re-arranged using drag and drop option
- Confirmed that removed sites can be readded via + add to sidebar option
- Confirmed that sites added in the normal tab are shown in the PT/TOR tabs
- Confirmed that new sites can be added via PT/TOR tabs and added sites are shown across all the tab types
- Confirmed that remove a site from the normal tab/tor/PT removes the site from other tabs
- Confirmed that sites added in the sidebar are retained in the new windows
example | example | example | example |
---|---|---|---|
Wallet permission prompts - SKIPPED (covered elsewhere)
First run dialog - PASSED
- Confirmed first run dialog is shown when Brave is installed
- Confirmed that Brave is kept docked when
Keep in Dock
checkbox is checked and clicked onSet Brave as default
- Confirmed that
Brave is already in Dock
text is shown inbrave://settings/getStarted
- Right-clicked on the Brave icon in the dock, and ensured Brave was docked
- Confirmed that Brave is not docked by toggling
Keep in Dock
off - Confirmed that
Dock
button is shown inbrave://settings/getStarted
when Brave is undocked - Launched Brave without clicking on the
Keep in Dock
andSet Brave as default
options, openbrave://settings/getStarted
and ensuredKeep in Dock
text is shown - Clicked on the
Dock
button viabrave://settings/getStarted
and ensured Brave is kept in the dock - Launched Brave without clicking on
Keep in Dock
andSet Brave as default
options, right-clicked on the Brave icon is the taskbar and selectOptions
->Keep in Dock
, and ensured Brave was kept in the dock
Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|
Sync (device types in the sync info) - PASSED
- Confirmed that no of devices in sync chain is shown correctly in brave://sync-internals
- Confirmed that passwords are synced across all the devices
- Confirmed that extensions are synced across all the devices in a sync chain
- Confirmed that open tabs synces across all the devices
- Confirmed that synced bookmarks are shown in the sidebar in a normal tab
- Confirmed that synced bookmarks are shown in the sidebar in a private tab
- Confirmed that synced bookmarks are shown in the sidebar in a private tab
- Confirmd that synced bookmarks cab be opened in PT/TOR tabs
- Confirmed able to create a standalone sync chain
- Confirmed reset sync chain remove all devices from the sync chain
- Confirmed able to join an existing sync chain using code words
- Confirmed device name is shown properly when sync chain is created
- Confirmed able to add a new mobile device to the chain via QR code/code words
- Confirmed existing bookmarks on current profile gets sync'd to all devices on the sync chain
- Confirmed folder structure is retained after sync completes
- Confirmed history is synced across all the devices when sync everything option is enabled
- Confirmed bookmarks don't duplicate when sync'd from other devices
- Confirmed removing bookmark from device gets sync'd to all devices on the sync chain
- Confirmed that synced bookmarks can be opened in a new tab
- Confirmed that sync everything works as expected
Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|
Settings comparison - PASSED
Confirmed new/renamed UI in brave://settings/cookies
, See all site data and permissions
, which used to be See all cookies and site data
Example | Example | Example (1.45.131) |
---|---|---|
Components updater - PASSED
Covered by manual test run: #26896
Brave startup calls - PASSED
Covered by manual test run: #26896
Verification passed on
Brave | 1.46.127 Chromium: 108.0.5359.48 (Official Build) (64-bit) |
---|---|
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854} |
OS | Ubuntu 18.04 LTS |
about:
screenshot
Areas:
Settings UI - PASSED
NTP background custom images (adding/removing) - PASSED
Use your own (custom bg image)
- Confirmed that user can select the custom background for NTP
- Confirmed that user can choose the induvidual custom background via NTP
- Confirmed that same custom background is shown on each the NTP when the induvidual gradient background is selected and
Refresh on every new tab
switch is OFF - Confirmed that different custom bg images shown on each NTP when
Refresh on every new tab
switch is ON - Confirmed that on each custom background color, the NTP stats (Cards, clock, Top sites, Brave stats etc) are shown clearly/correctly
- Confirmed that selected custom background retained on the NTP after the browser restart
- Confirmed that Check mark is shown on the selected custom background
- Confirmed that selected custom background retained across all the tabs and windows in Regular window
- Confirmed that selected custom background retained only for the Profile 1
- Confirmed that user has provision to select the different custom background colors for multiple profiles
- Confirmed that selecting custom background doesn't impact the NTP SI show on NTP
- Confirmed that NTP SI are shown in the order 2, 4, 8 tabs and confirmed custom background is checked the background images grid
Regression on NTP
- Ensured Tops sites can be edit/delete via NTP
- Ensured that NTP stats can be hidden/shown
- Ensured that a site can be added via NTP
- Ensured NTP Widget cards can be added/removed
- Ensured NTP SI works as expected
- Ensured that click on settings (bookmarks, history, settings and brave talk) shortcuts works as expected
- Ensured that the solid/gradient background images and Brave background works as expected
Sidebar (adding/removing items) - PASSED
Side panel:
- Confirmed that sidebar is shown by default in the nightly channel
- Confirmed that Reading list icon is added to the sidebar menu
- Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
- Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
- Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
- Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
- Confirmed that reading list icon is shown in the URL bar, next to wallet icon
- Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
- Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
- Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as
Add to current tab
option is not getting activated #24930 - Confirmed that sites can be segregated to Read and Unread list
- Confirmed that sites can be deleted from the reading list
Sidebar:
- Confirmed sites can be added to sidebar by clicking on + add to sidebar option
- Confirmed added sites can be edited via Edit option
- Confirmed that added sites can be removed via Remove option
- Confirmed that sidebar settings can be re-arranged using drag and drop option
- Confirmed that removed sites can be readded via + add to sidebar option
- Confirmed that sites added in the normal tab are shown in the PT/TOR tabs
- Confirmed that new sites can be added via PT/TOR tabs and added sites are shown across all the tab types
- Confirmed that remove a site from the normal tab/tor/PT removes the site from other tabs
- Confirmed that sites added in the sidebar are retained in the new windows
Wallet permission prompts - SKIPPED (covered elsewhere)
(covered by Shri)
First run dialog - PASSED
- Confirmed first run dialog is shown when Brave is installed
- Confirmed setting Brave as default makes it the default browser
Sync (device types in the sync info) - PASSED
- Confirmed that no of devices in sync chain is shown correctly in brave://sync-internals
- Confirmed that passwords are synced across all the devices
- Confirmed that extensions are synced across all the devices in a sync chain
- Confirmed that open tabs synces across all the devices
- Confirmed that synced bookmarks are shown in the sidebar in a normal tab
- Confirmed that synced bookmarks are shown in the sidebar in a private tab
- Confirmed that synced bookmarks are shown in the sidebar in a private tab
- Confirmd that synced bookmarks cab be opened in PT/TOR tabs
- Confirmed able to create a standalone sync chain
- Confirmed reset sync chain remove all devices from the sync chain
- Confirmed able to join an existing sync chain using code words
- Confirmed device name is shown properly when sync chain is created
- Confirmed able to add a new mobile device to the chain via QR code/code words
- Confirmed existing bookmarks on current profile gets sync'd to all devices on the sync chain
- Confirmed folder structure is retained after sync completes
- Confirmed history is synced across all the devices when sync everything option is enabled
- Confirmed bookmarks don't duplicate when sync'd from other devices
- Confirmed removing bookmark from device gets sync'd to all devices on the sync chain
- Confirmed that synced bookmarks can be opened in a new tab
- Confirmed that sync everything works as expected
Settings comparison - PASSED
Confirmed new/renamed UI in brave://settings/cookies
, See all site data and permissions
, which used to be See all cookies and site data
Components updater - PASSED
Covered by manual test run: #26899
Brave startup calls - PASSED
Covered by manual test run: #26899
Changing to |
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/108.0.5359.40..108.0.5359.48?pretty=fuller&n=10000
QA tests:
macOS
,Linux
, andAndroid Tablet
need affected areas to be checked as listed in Upgrade from Chromium 107 to Chromium 108. #25703 (comment).Windows
andAndroid ARM
already checked these areas as per Upgrade from Chromium 107 to Chromium 108. #25703 (comment) and Upgrade from Chromium 107 to Chromium 108. #25703 (comment).Additional checks:
The text was updated successfully, but these errors were encountered: