Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 108.0.5359.48 to Chromium 108.0.5359.62. #27016

Closed
mkarolin opened this issue Nov 28, 2022 · 6 comments · Fixed by brave/brave-core#16114
Closed

Upgrade from Chromium 108.0.5359.48 to Chromium 108.0.5359.62. #27016

mkarolin opened this issue Nov 28, 2022 · 6 comments · Fixed by brave/brave-core#16114

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/108.0.5359.48..108.0.5359.62?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.46.130 or higher for 1.46.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Nov 29, 2022

As per #26820 (comment), macOS, Linux and Tablet were left regarding running through the affected areas. Looks like macOS & Linux were completed via #26820 (comment).

Double checking with @Uni-verse if we still need to run through the affected areas on Tablet. Looks like there's an update via #25703 (comment) but most of the screenshots like mobile/phone related. There's also #26820 (comment) but that only checked to ensure that the branding is being displayed correctly and the correct bump is being used.

@Uni-verse please let me know if we still need to run through the Tablet checks. Or if they were completed via #25703 (comment) but screenshots not added other than the Tab Switcher Animation section.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 29, 2022

Verification PASSED on

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit)
-- | --
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Windows 10 Version 21H2 (Build 19044.2251)

image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version:

Brave	1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit) 
Revision	041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS	Android 12; Build/SP1A.210812.016
Example Example
screenshot-1669735423494 screenshot-1669735596296

@btlechowski
Copy link

Verification passed on

Brave 1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit)
Revision 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS Ubuntu 18.04 LTS

image

@kjozwiak
Copy link
Member

Labelling as release-notes/exclude in favour of #27041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants