Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 108.0.5359.48 to Chromium 108.0.5359.62. #16114

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Upgrade from Chromium 108.0.5359.48 to Chromium 108.0.5359.62. #16114

merged 3 commits into from
Nov 29, 2022

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#27016

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Nov 28, 2022
@mkarolin mkarolin requested review from a team as code owners November 28, 2022 18:48
@mkarolin mkarolin self-assigned this Nov 28, 2022
@mkarolin
Copy link
Collaborator Author

There's a Chromium browser tests failure on Windows for MetricIntegrationTest.FirstInputDelay test which is known to be flaky (always passes locally). This test failure can be ingnored.

@kjozwiak kjozwiak requested a review from a team November 29, 2022 00:28
kjozwiak
kjozwiak approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Approving & Merging into master so we can get #16119 & #16120 merged/uplifted.

@kjozwiak kjozwiak merged commit 2212885 into master Nov 29, 2022
@kjozwiak kjozwiak deleted the 108.0.5359.62_master branch November 29, 2022 00:29
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: b6ba209
reason: unsigned
Please follow the handbook to configure commit signing
cc: @brave-browser-releases

@kjozwiak kjozwiak added this to the 1.48.x - Nightly milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 108.0.5359.48 to Chromium 108.0.5359.62.
3 participants
@mkarolin @kjozwiak @brave-browser-releases