Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update text on Tips panel - follow up to 2499 #2695

Closed
LaurenWags opened this issue Dec 21, 2018 · 3 comments · Fixed by brave/brave-core#1419
Closed

update text on Tips panel - follow up to 2499 #2695

LaurenWags opened this issue Dec 21, 2018 · 3 comments · Fixed by brave/brave-core#1419
Assignees
Labels
feature/rewards needs-text-change This change requires some careful wording. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Follow up to issue 2499

Issue 2499 addressed removing text about tipping on like from Tips panel, however, if Rewards are turned off the Tips panel still mentions tipping on 'Like' and Twitter. This other text can also be seen when Tips panel is viewed immediately after Rewards are enabled, before any sites are visited.

Steps to Reproduce

  1. Clean profile
  2. Enable Rewards
  3. Before visiting any sites, view Tips panel on brave://rewards
  4. If Rewards are already enabled, turn them off.

Actual result:

Text in bullet points mentions Twitter and tipping on Like.
screen shot 2018-12-21 at 4 29 59 pm

Expected result:

Text would be adjusted since tipping Tweets and on 'Like' is not yet implemented.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta(64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @mandar-brave @rebron

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Dec 21, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 3, 2019
@NejcZdovc
Copy link
Contributor

@davidtemkin what should be a text here?

@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jan 19, 2019
@davidtemkin
Copy link

The bullet point text should be:

"Tip on the spot as you find gems."
"Support your favorite sites with recurring monthly tips."

@NejcZdovc NejcZdovc self-assigned this Jan 21, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 23, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 23, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Feb 8, 2019

Verified passed with

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

image

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-text-change This change requires some careful wording. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants