Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to Tip-panel and Tip-banner for unverified publishers #2697

Closed
mandar-brave opened this issue Dec 22, 2018 · 5 comments · Fixed by brave/brave-core#1183
Closed

Comments

@mandar-brave
Copy link

mandar-brave commented Dec 22, 2018

Add Note to Tip-Panel below the Send-Tip button

Note: has not signed up to claim your contributions. Click here to contribute only to sites that have signed up.

Link, when clicked, will auto-toggle the settings on Brave-Rewards for Auto-contribute and Tips to OFF for unverified publishers

Add Note to Tip-Banner

Note: This creator has not yet signed up to claim tips from Brave users, but we hope they will soon! For more info, click here <link: https://brave.com/faq-rewards/#unclaimed-funds>

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Dec 22, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 22, 2018
@NejcZdovc NejcZdovc added this to the 0.58.x - Release Hotfix 1 milestone Dec 22, 2018
@jenn-rhim
Copy link

jenn-rhim commented Dec 22, 2018

Here is the fix.

screen shot 2018-12-22 at 12 17 47 pm

screen shot 2018-12-22 at 12 17 33 pm

*Be sure to change the copy in the main content area: 'Content creators get paid...' to 'Verified content creators...' --> this is for all banners, banner with or without the disclaimer box at the top.

@NejcZdovc @mandar-brave

@davidtemkin
Copy link

@NejcZdovc @mandar-brave @jenn-rhim

In the BR panel, the link/button "Change Auto-Contribute Settings" should only appear if a user has enabled Auto-Contribute as a whole.

If A-C is on, the link/button should appear even if the user has previously disabled "allow contribution to non-verified sites" in A-C settings.

@davidtemkin
Copy link

When a user presses "Change Auto-Contribute Settings", the user should be taken to the Brave Rewards settings page, with Auto-Contribute settings pre-opened. @NejcZdovc

@mandar-brave
Copy link
Author

@NejcZdovc removed the original references now that we have the newly designed images from @jenn-rhim

@kjozwiak
Copy link
Member

kjozwiak commented Dec 23, 2018

Went through verifications on the following platforms:

  • macOS 10.14.2 x64 - Verification PASSED
  • Ubuntu 18.04.1 x64 VM - Verification PASSED

Used the following build:

Brave 0.58.17 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}

screen shot 2018-12-23 at 7 23 06 am

screen shot 2018-12-23 at 7 23 19 am

Test Cases:

  • ensured that Learn more under the Rewards panel takes the user to https://brave.com/faq-rewards/#unclaimed-funds
  • ensured that Learn more under the Tip banner panel opens https://brave.com/faq-rewards/#unclaimed-funds
  • ensured that Change Auto-Contribution Settings under the Rewards panel opens brave://rewards/#ac-settings
  • ensured that Change Auto-Contribute settings is being displayed under the Rewards panel when Allow contribution to non-verified sites is enabled via chrome://rewards/#ac-settings
  • ensured that Change Auto-Contribute settings doesn't appear under the Rewards panel when Allow contribution to non-verified sites is disabled via chrome://rewards/#ac-settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants