Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening multiple confirm dialogues #27474

Closed
Sajarin-M opened this issue Dec 20, 2022 · 4 comments · Fixed by brave/brave-core#16657
Closed

Opening multiple confirm dialogues #27474

Sajarin-M opened this issue Dec 20, 2022 · 4 comments · Fixed by brave/brave-core#16657
Assignees
@simonhong
Labels
OS/Desktop OS/Linux QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.49.x - Release

Comments

@Sajarin-M
Copy link

Description

Opening multiple close all tabs confirm dialog when using short cut key ( Alt +f4 ) for closing Brave

Steps to Reproduce

  1. Press Alt + f4 multiple times to close the browser with more than 1 tabs opened.

Actual result:

Opens multiple confirm dialogues

Expected result:

Should not open confirm dialog if there is already one

Reproduces how often:

Brave version (brave://version info)

 Version 1.46.144
@rebron
Copy link
Collaborator

rebron commented Dec 22, 2022

Hi @Sajarin-M. What operating system are you using?

@rebron rebron added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Dec 22, 2022
@Sajarin-M
Copy link
Author

Hi @Sajarin-M. What operating system are you using?

Fedora 37

@simonhong
Copy link
Member

@Sajarin-M I also can repro this on ubuntu. Thanks for reporting!

@simonhong simonhong self-assigned this Dec 23, 2022
@simonhong simonhong added OS/Linux and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 23, 2022
@simonhong simonhong mentioned this issue Jan 13, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jan 13, 2023
@simonhong
Prevent multiple closing confirm dialog creation
fd06f8c 
fix brave/brave-browser#27474

On linux, user can request windows closing with Alt+F4 while
closing confirm dialog is running.
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 16, 2023
@btlechowski
Copy link

Reproduced on 1.48.171

27474

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified only one dialog is shown
27474b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop OS/Linux QA Pass-Linux QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Prevent multiple closing confirm dialog creation brave/brave-core
5 participants
@rebron @simonhong @btlechowski @brave-builds @Sajarin-M