Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/ character appearing within the summary text of the Privacy Report notification warning modal #27740

Closed
kjozwiak opened this issue Jan 11, 2023 · 2 comments · Fixed by brave/brave-core#16616

Comments

@kjozwiak
Copy link
Member

Description

The You're not receiving Privacy Reports modal has a \ character within the summary text. Looks a character escape issue. Ran into the following while verifying brave/brave-core#16128.

Steps to reproduce

  1. download/install 1.49.16 Chromium: 109.0.5414.87
  2. run through onboarding and ensure that you enable OS notifications
  3. tap on Privacy Stats via NTP and enable the feature via the onboarding (or via Settings -> Privacy Report)
  4. once the Privacy Report is enabled, disable All "General" notifications via Settings -> Notifications
  5. click on the <- (back button) and you should recieve a modal warning the user re: not receiving reports due to notifications being disabled

Actual result

Screenshot_20230111-020335

Expected result

Shouldn't be displaying the \ character within the summary/string.

Issue reproduces how often

100% reproducible using the STR mentioned above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
  • Android version: Android 13

Brave version

Brave | 1.49.16 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B1.221118.006

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @deeppandya @sujitacharya2005 @timchilds

@kjozwiak
Copy link
Member Author

The above requires 1.47.171 or higher for 1.47.x verification 👍

@kjozwiak
Copy link
Member Author

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.22 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B1.221118.006

Using the STR/Cases outlined via #27740 (comment), ensured that the \ character was removed from the summary string of the Privacy Report notification warning modal as per the following:

Example Example
Screenshot_20230112-131541 Screenshot_20230112-131732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants