Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show NFT section on portfolio #27777

Closed
Pavneet-Sing opened this issue Jan 12, 2023 · 2 comments · Fixed by brave/brave-core#16643
Closed

Show NFT section on portfolio #27777

Pavneet-Sing opened this issue Jan 12, 2023 · 2 comments · Fixed by brave/brave-core#16643
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Show NFT section under crypto list

Expected result

Screenshot from 2023-01-12 21-51-06
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 12, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 12, 2023
@Pavneet-Sing Pavneet-Sing moved this to In Review in Web3 Jan 12, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 12, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 13, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 13, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 24, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.48.141 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on the following devices running

  • Verified steps from brave/brave-core#16671
  • Verified NFT is listed under its own heading in portfolio page
  • Verified NFT image/gif is shown on portfolio page
  • Verified clicking on NFT loads the NFT details view
  • Verified NFT is shown and can be viewed for both Ethereum NFT and Solana NFT
  • Verified changing network in network filter updates the NFT view and removes it
  • Encountered #28301
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27777-ARM.mp4

This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): show nft section in portfolio brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds