Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): show nft section in portfolio #16643

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Jan 12, 2023

  • Fix touch issue on graph for smooth scroll
  • Fix portfolio screen UI

Resolves brave/brave-browser#27777

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

portfolio-nft.webm
portfolio-nft.webm

Additional Info

SVGs cannot be supported currently, need extra libs to use. Simone will create a separate issue to add support for SVGs.

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 12, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 12, 2023
@Pavneet-Sing Pavneet-Sing force-pushed the feat-show-nft-section-on-portfolio branch from 6a76d5b to 6ca9c6e Compare January 12, 2023 16:32
@Pavneet-Sing Pavneet-Sing force-pushed the feat-show-nft-section-on-portfolio branch 2 times, most recently from 5ffba0e to b7b8e2b Compare January 12, 2023 17:39
Copy link
Collaborator

@simoarpe simoarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, code looks good 👍
Nit: I would try to merge the two methods in the ImageLoader.

@Pavneet-Sing Pavneet-Sing force-pushed the feat-show-nft-section-on-portfolio branch 2 times, most recently from 49ed46a to 8db2b05 Compare January 12, 2023 18:42
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

- Fix touch issue on graph for smooth scroll
- Fix portfolio screen UI
@Pavneet-Sing Pavneet-Sing force-pushed the feat-show-nft-section-on-portfolio branch from 8db2b05 to e9f3614 Compare January 13, 2023 10:57
@Pavneet-Sing Pavneet-Sing enabled auto-merge (squash) January 13, 2023 11:12
@Pavneet-Sing Pavneet-Sing merged commit 5b04547 into master Jan 13, 2023
@Pavneet-Sing Pavneet-Sing deleted the feat-show-nft-section-on-portfolio branch January 13, 2023 11:30
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 13, 2023
Pavneet-Sing pushed a commit that referenced this pull request Jan 24, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.49.58 x64 build

  • Verified steps from PR
  • Verified NFT is listed under its own heading in portfolio page
  • Verified NFT image/gif is shown on portfolio page
  • Verified clicking on NFT loads the NFT details view
  • Verified NFT is shown and can be viewed for both Ethereum NFT and Solana NFT
  • Verified changing network in network filter updates the NFT view and removes it
16643.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show NFT section on portfolio
4 participants