-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): show nft section in portfolio #16643
Conversation
6a76d5b
to
6ca9c6e
Compare
android/java/org/chromium/chrome/browser/app/domain/PortfolioModel.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/crypto_wallet/util/ImageLoader.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/crypto_wallet/util/ImageLoader.java
Show resolved
Hide resolved
5ffba0e
to
b7b8e2b
Compare
android/java/org/chromium/chrome/browser/crypto_wallet/util/ImageLoader.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/crypto_wallet/util/ImageLoader.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/crypto_wallet/util/ImageLoader.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/app/domain/PortfolioModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, code looks good 👍
Nit: I would try to merge the two methods in the ImageLoader
.
android/java/org/chromium/chrome/browser/crypto_wallet/util/ImageLoader.java
Outdated
Show resolved
Hide resolved
49ed46a
to
8db2b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
- Fix touch issue on graph for smooth scroll - Fix portfolio screen UI
8db2b05
to
e9f3614
Compare
Verification passed on Oppo Reno 5 with Android 13 running 1.49.58 x64 build
16643.mp4 |
Resolves brave/brave-browser#27777
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
portfolio-nft.webm
portfolio-nft.webm
Additional Info
SVGs cannot be supported currently, need extra libs to use. Simone will create a separate issue to add support for SVGs.