"Not now" off the screen in portrait mode

[jidanni]

The user sees this prompt again and again, because in portrait orientation the "not now" option is off the side of the screen. Yes this only affects some users who have larger font needs. Thus it is an accessibility problem.

[kjozwiak]

@jidanni thanks for the report/issue? Mind sharing some more information so we can try reproducing/fixing the above ASAP? Which version of Android are you on and what device are you using? Looks like the viewport is pretty small. Assuming one of the smaller devices?

[AlexeyBarabash]

Experiencing the same issue.
Device: Samsung Note 8
OS: Android 8
Browser version: 1.47.178

STR:

1. Uninstall Brave Stable (if installed)
2. Install the latest Brave Stable from GP
3. Go through onboarding wizard
   See
   

Additional not: I can't reproduce it on any other my Android device.

[jidanni]

The main thing you need to test, is in your Android settings, make the font size super large, and the screen zoom setting also super large. Yes it's for old people bad eyes. You will see the problem even even at just a little larger than normal. Android 12 Samsung A13 5G.

[AlexeyBarabash]

At #27825 (comment) zoom settings and text scale are default.

On my other phone I changed these settings to max values and the button is drawn well

Description	Screenshot
Settings 1
Settings 2
Brave screen

[jidanni]

I remember I already successfully hit it in Landscape mode, so can no longer reproduce without reinstalling the app, etc.
So I hope other people can work on testing this bug.

[SergeyZhukovsky]

I didn't manage to replicate the Not Now button is off, but I remade that place and fixed the Add Widget button.

[SergeyZhukovsky]

We will open another issue if face a problem with a Now now button.

[kjozwiak]

The above requires 1.47.190 or higher for 1.47.x verification 👍

[kjozwiak]

Moving this into 1.48.x as we neve received another C109 minor chromium bump that would have triggered another 1.47.x release. We'll leave https://github.com/brave/brave-core/milestone/267 as there's code that landed in 1.47.x but we'll close off the 1.47.x - Release #6 milestone and move all the issues within 1.48.x.

The above can be verified with 1.48.156 for 1.48.x as it's been merged into a 1.48.x a while ago as per brave/brave-core#16927.

[kjozwiak]

Verification PASSED on Pixel 6 Pro running Android 8 via the Android Studio Emulator using the following build(s):

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (32-bit)
--- | ---
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Android 8.0.0; Build/OSR1.180418.026

• ensured that tapping on Add Widget via the onborading worked without any issues
• ensured that tapping on Not now correctly dismissed the widget onboarding without any issues

Example	Example

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (32-bit)
--- | ---
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Android 13; Build/TQ1A.230105.002

• ensured that tapping on Add Widget via the onborading worked without any issues
• ensured that tapping on Not now correctly dismissed the widget onboarding without any issues

Example	Example