Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP712Domain data should be displayed #28048

Closed
kdenhartog opened this issue Jan 25, 2023 · 2 comments · Fixed by brave/brave-core#16935
Closed

EIP712Domain data should be displayed #28048

kdenhartog opened this issue Jan 25, 2023 · 2 comments · Fixed by brave/brave-core#16935
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.48.x - Release

Comments

@kdenhartog
Copy link
Member

kdenhartog commented Jan 25, 2023 •
edited by diracdeltas
Loading

see https://hackerone.com/reports/1847102

credit: https://hackerone.com/julianor
@kdenhartog kdenhartog added security feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/core labels Jan 25, 2023
@kdenhartog kdenhartog changed the title EIP712Domain data should be validated EIP712Domain data should be displayed and validated Jan 25, 2023
@kdenhartog kdenhartog changed the title EIP712Domain data should be displayed and validated EIP712Domain data should be displayed Jan 26, 2023
@kdenhartog kdenhartog added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jan 26, 2023
@supermassive supermassive mentioned this issue Jan 31, 2023
Merged
25 tasks
@yrliou yrliou added this to Web3 Jan 31, 2023
@yrliou yrliou moved this to In Progress in Web3 Jan 31, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 2, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 2, 2023
This was referenced Feb 2, 2023
Closed
Merged
Merged
@yrliou yrliou added priority/P2 A bad problem. We might uplift this to the next planned release. and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Feb 2, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2023

The above requires 1.48.156 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on

Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 11 Version 22H2 (Build 22621.1105)
  • Verified domain info is shown on signing messages for v3/v4 messages
Personal Sign Sing Type v3 Sign Type v4
image image image

Verification passed on Oppo Reno 5 with Android 13 running 1.48.157 x64 build

  • Verified domain info is shown on signing message for v3/v4 messages
28048.mp4

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Feb 6, 2023
Closed
This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Show domain info when signing messages brave/brave-core
6 participants
@supermassive @kjozwiak @yrliou @srirambv @kdenhartog @brave-builds