Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

EIP712Domain data should be displayed #6892

Closed
StephenHeaps opened this issue Feb 6, 2023 · 1 comment · Fixed by #6911
Closed

EIP712Domain data should be displayed #6892

StephenHeaps opened this issue Feb 6, 2023 · 1 comment · Fixed by #6911
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include security
Milestone
1.48

Comments

@StephenHeaps
Copy link
Contributor

Description:

iOS version of brave/brave-browser#28048

cc @kdenhartog
@StephenHeaps StephenHeaps added this to Web3 Feb 6, 2023
@StephenHeaps StephenHeaps added this to the 1.48 milestone Feb 6, 2023
@StephenHeaps StephenHeaps self-assigned this Feb 8, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Feb 8, 2023
@StephenHeaps StephenHeaps mentioned this issue Feb 8, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Feb 10, 2023
@StephenHeaps
Fix #6892: Display domain info for signature requests (#6911)
e60cd4a 
* Display domain info in `SignatureRequestView`

* Add optional `NSAttributedString` support to `StaticTextView`. Use an attributed string to display Domain/Message titles in bold when domain is displayed, otherwise just display the message.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 10, 2023
@StephenHeaps StephenHeaps mentioned this issue Feb 16, 2023
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 15.7.1 running 1.48 (23.2.22.16)

  • Verified steps from #6911
  • Verified EIP712 domain data is shown in sign transaction confirmation screen
6892-iPhone.XR.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.48
Development

Successfully merging a pull request may close this issue.

Fix #6892: Display domain info for signature requests brave/brave-ios
2 participants
@StephenHeaps @srirambv