Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C110] More Info link on Help improve Brave Search... info bar doesn't work #28139

Closed
MadhaviSeelam opened this issue Jan 30, 2023 · 3 comments · Fixed by brave/brave-core#17121
Assignees

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 30, 2023

Description

Found this issue while testing #27221. More info link in the infobar on the Search results page doesn't navigate to Web Discovery Project information page,

Steps to Reproduce

  1. Install 1.49.69
  2. launch Brave
  3. open a new-tab
  4. confirmed Brave is default search engine in brave://settings/search
  5. search by a string hello
  6. WDP infobar shown with text Help improve Brave Search...
  7. click More info link

Actual result:

Nothing happens when clicked on More info link
image

Expected result:

More info link should open to https://brave.com/privacy/browser/#web-discovery-project
image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.49.69 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @emerick
cc: @brave/qa-team

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 31, 2023
@simonhong simonhong self-assigned this Feb 8, 2023
@simonhong
Copy link
Member

It seems More info link doesn't work when it's located in the second row.

@simonhong
Copy link
Member

simonhong commented Feb 9, 2023

It looks like a link in views::StyledLabel() doesn't work well when StyledLabel() is multilined. Investigating.

@stephendonner
Copy link

stephendonner commented Mar 13, 2023

Verified PASSED using

Brave 1.50.90 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Steps:

  1. installed 1.50.90
  2. launched Brave
  3. opened a new-tab page
  4. typed "hello" into the URL bar and hit return
  5. clicked on More info in the resulting infobar which popped up
  6. confirmed it loaded https://brave.com/privacy/browser/#web-discovery-project in a new tab
example example
Screen Shot 2023-03-13 at 3 42 10 PM Screen Shot 2023-03-13 at 3 42 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants