Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache private search provider's template url data #28360

Closed
simonhong opened this issue Feb 8, 2023 · 5 comments · Fixed by brave/brave-core#17015 or brave/brave-core#17094
Closed

Cache private search provider's template url data #28360

simonhong opened this issue Feb 8, 2023 · 5 comments · Fixed by brave/brave-core#17015 or brave/brave-core#17094
Assignees
@simonhong
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Feb 8, 2023 •
edited
Loading

As we can update default search provider list in the future, we should cache private search provider's template url data.
If we can use cached template url data for private window's search provider, we can set and use previous default search provider
even if new default search provider list doesn't include it.

  • STR
  1. Load brave://prefs-internals/
  2. check default_private_search_provider_data is cached
  3. check default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same
@simonhong simonhong self-assigned this Feb 8, 2023
@simonhong simonhong mentioned this issue Feb 8, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 8, 2023
@simonhong
Cache private search provider's template url data
7153949 
fix brave/brave-browser#28360

Cached default private search provider is added to list
when it's not included in default provider list.

So far Brave is set when previous default one is not included in
the default list. We should set previous one as a default
when new default list is changed and it's not included.
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 8, 2023
simonhong added a commit to brave/brave-core that referenced this issue Feb 8, 2023
@simonhong
Reset TemplateURLData::id before adding to TemplateURLService
43681f7 
New id is assigned when it's added.

f/u PR for #17015

fix brave/brave-browser#28360
@simonhong simonhong mentioned this issue Feb 8, 2023
Merged
25 tasks
@LaurenWags
Copy link
Member

@simonhong are there any other pre-requisites for this? I visited brave://prefs-internals/ and searched for default_private_search_provider_data but it wasn't found.

Maybe I missed some steps? Any additional information is appreciated.

@simonhong
Copy link
Member Author

simonhong commented Mar 15, 2023 •
edited
Loading

@LaurenWags Hmm, it's strange. There is no prerequisites for this.
I can see default_private_search_provider_data with fresh profile or existing profile both.
image

@LaurenWags
Copy link
Member

Thanks @simonhong I'll try again - I thought I copied and pasted the search item, but perhaps I mistyped it instead 🤔

@LaurenWags
Copy link
Member

LaurenWags commented Mar 15, 2023 •
edited by btlechowski
Loading

Verified with

Brave | 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

Verified test plan from brave/brave-core#17015 (comment).

Clean Profile - PASSED

Ran through below cases using a clean install of 1.50.x.

Default Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is unchanged.

Default Private Window SE brave://prefs-internals
1a 1b
Modified Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is modified.

Default Private Window SE brave://prefs-internals
2a 2b
Upgrade Profile - PASSED

Ran through the below cases after upgrading from 1.49.120.

Default Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is unchanged.

1.49.120 Default Private Window SE 1.50.91 Default Private Window SE brave://prefs-internals
1 2 3
Modified Private Window SE - PASSED

Modified the Private Window SE on 1.49.120 and then upgraded to 1.50.91.

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is modified.

1.49.120 Default Private Window SE 1.50.91 Default Private Window SE brave://prefs-internals
1 2 3

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#17015 (comment).

Clean Profile - PASSED

Ran through below cases using a clean install of 1.50.x.

Default Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is unchanged.

Default Private Window SE brave://prefs-internals
image image
Modified Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is modified.

Default Private Window SE brave://prefs-internals
image image
Upgrade Profile - PASSED

Ran through the below cases after upgrading from 1.49.120.

Default Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is unchanged.

image image image
Modified Private Window SE - PASSED

Modified the Private Window SE on 1.49.120 and then upgraded to 1.50.93.

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is modified.

image image

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/Blocked QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 15, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 27, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 27, 2023 •
edited
Loading

Verification PASSED

Brave | 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Verified test plan from brave/brave-core#17015 (comment).

Clean Profile - PASSED
Default Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is unchanged.

Default Private Window SE brave://prefs-internals
image image
Modified Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is modified.

Default Private Window SE brave://prefs-internals
image image
Upgrade Profile - PASSED

Ran through the below cases after upgrading from 1.49.120.

Default Private Window SE - PASSED

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is unchanged.

1.49.120 Default Private Window SE 1.50.91 Default Private Window SE brave://prefs-internals
image image image
Modified Private Window SE - PASSED

Modified the Private Window SE on 1.49.120 and then upgraded to 1.50.91.

Confirmed default_private_search_provider_data.synced_guid and default_private_search_provider_guid is same under brave://prefs-internals/ when default SE for private window is modified.

1.49.120 Default Private Window SE 1.50.91 Default Private Window SE brave://prefs-internals
image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
5 participants
@simonhong @LaurenWags @btlechowski @brave-builds @MadhaviSeelam