Session cookies are persisted on session restore #28379

goodov · 2023-02-08T16:54:59Z

Chromium implements session cookie restore to persist them during updates (browser restart), but this is also applied when "Continue where you left off" is enabled. It's unclear if this is intentional, but this in fact allows these cookies to live much longer than other "persisted" cookie variants.

You can try this test https://bayden.com/test/sessions/
All Chromium browsers persists session cookies (but not sessionStorage) across page closes and browser resets in "Continue where you left off" mode.

An article from Eric Lawrence which also covers this topic:
https://textslashplain.com/2019/06/24/surprise-undead-session-cookies/

Note (by @ShivanKaul): this issue was fixed by brave/brave-core#17122 for all platforms except MacOS.

goodov · 2023-02-14T16:21:38Z

Note for @brave/qa-team - Need to run test cases 1, 2, 4 on Linux. Test case 3 is N/A. Should run 1, 2, 3, 4 on Windows and macOS.

Test case 1 (quit+open)

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has changed to no value.

Test case 2 (brave://restart)

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Test case 3 (browser update)

Install slightly old nightly version which includes this fix, but which will want to update.
Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Apply update via "Update" button, browser should restart automatically.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Test case 4 (disabled feature, old behavior)

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Launch browser with --disable-features=BraveCleanupSessionCookiesOnSessionRestore.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

LaurenWags · 2023-03-16T16:26:49Z

Verified with

Brave | 1.50.92 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

Verified test plan from #28379 (comment).

Test Case 1 (quit + open) - PASSED

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has changed to undefined.

Note, confirmed with @goodov that sessionCookie has no value is ok here, the main thing is that this sessionCookie does not say lightcyan.

Step 1	Step 3	Step 6	Step 8

Test case 2 (brave://restart) - PASSED

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Step 1	Step 3	Step 5	Step 7

Test case 3 (browser update) - FAILED, follow up issue logged

Install slightly old beta version which includes this fix, but which will want to update. (I used 1.50.86)
Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Navigate to brave://settings/help and apply update via "Relaunch" button, browser should restart automatically.
Expect the session is restored and the website is still opened.
Navigate to test page and refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan. However, it is not. Logged session cookie not persisted on restart when applying browser update - follow up to 28379 #29135 as a follow up.

Step 1	Step 2	Step 4	Step 5	Step 8

Test case 4 (disabled feature, old behavior) - PASSED

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Launch browser with --disable-features=BraveCleanupSessionCookiesOnSessionRestore.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Logs from step 5:

laurenwags@Laurens-MBP ~ % /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --disable-features=BraveCleanupSessionCookiesOnSessionRestore
[17908:259:0317/133341.048336:WARNING:chrome_main_delegate.cc(618)] This is Chrome version 111.1.50.92 (not a warning)
[17908:259:0317/133341.313808:WARNING:external_provider_impl.cc(503)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
objc[17917]: Class WebSwapCGLLayer is implemented in both /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib (0x7ffb5c20fec8) and /Applications/Brave Browser Beta.app/Contents/Frameworks/Brave Browser Beta Framework.framework/Versions/111.1.50.92/Libraries/libGLESv2.dylib (0x1074aa850). One of the two will be used. Which one is undefined.
[17908:259:0317/133342.387026:INFO:CONSOLE(12)] "{"sessionColor":"lightcyan"}", source: https://bayden.com/test/sessions/ (12)

Step 1	Step 3	Step 8

Regression set 1 - "Open the New Tab page" setting - PASSED

Case 1:

Ensure "Open the New Tab page" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 9

Case 2:

Ensure "Open the New Tab page" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 7

Case 3:

Install slightly old version which will want to update. (I used 1.50.86)
Ensure "Open the New Tab page" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Navigate to brave://settings/help and apply update via "Relaunch" button, browser should restart automatically.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 2	Step 4	Step 9

Regression set 2 - "Open a specific page or set of pages" setting - PASSED

Case 1:

Ensure "Open a specific page or set of pages" is enabled (have at least one page configured like brave.com)
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 9

Case 2:

Ensure "Open a specific page or set of pages" is enabled (have at least one page configured like brave.com)
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 7

Case 3:

Install slightly old version which will want to update. (I used 1.50.86)
Ensure "Open a specific page or set of pages" is enabled (have at least one page configured like brave.com)
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Navigate to brave://settings/help and apply update via "Relaunch" button, browser should restart automatically.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 2	Step 4	Step 9

goodov · 2023-03-17T13:51:55Z

Test case 3 (browser update) - FAILED, follow up issue logged

I dig a little and found a PR which tries to fix the restart on MacOS. Right now it doesn't work as expected, instead it's pretty crazy how the "update restart" currently actually works on MacOS (in a bad way).

https://github.com/brave/brave-core/pull/15257/files#r1140262599

MadhaviSeelam · 2023-03-24T17:27:00Z

Verification PASSED using

Brave | 1.50.101 Chromium: 111.0.5563.116 (Official Build) beta (64-bit)
-- | --
Revision | ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Verified test plan from #28379 (comment).

Test Case 1 (quit + open) - PASSED

1. Install 1.50.101 2. launch Brave 3. visit `brave://settings` and confirm "Continue where you left off" is enabled 4. Open https://bayden.com/test/sessions/ and choose `lightcyan` from selector. 5. Ensure `sessionCookie says color is: lightcyan`. 6. Fully quit browser. 7. Open browser. 8. Expect the session is restored and the website is still opened. 9. Refresh the page (Ctrl/Cmd+R). 10. Expect `sessionCookie` **has changed to** `undefined`.

Note, confirmed with @goodov that sessionCookie has no value is ok here, the main thing is that this sessionCookie does not say lightcyan.

step 3	step 5	step 8	step 10

Test Case 2 (Exit + open) - PASSED

Install 1.50.101
launch Brave
visit brave://settings and confirm "Continue where you left off" is enabled
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
quit browser via hamburger menu>>Exit
Open browser.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has changed to undefined.

Note, confirmed with @goodov that sessionCookie has no value is ok here, the main thing is that this sessionCookie does not say lightcyan.

step 3	step 5	step 6	step 10

Test case 3 (brave://restart) - PASSED

new profile
launch Brave
Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Step 3	Step 5	Step 7	Step 9

Test case 4 (browser update) - PASSED

Install slightly old beta version which includes this fix, but which will want to update. (I used 1.50.86)
Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Navigate to brave://settings/help and apply update via "Relaunch" button, browser should restart automatically.
Expect the session is restored and the website is still opened.
Navigate to test page and refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Step 1	Step 2	Step 4	Step 5	Step 8

Test case 5 (disabled feature, old behavior) - PASSED

new profile
launch Brave
close and relaunch Brave
Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Launch browser with --disable-features=BraveCleanupSessionCookiesOnSessionRestore.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

step 2	step 3	step 4	step 6	step 11

Regression set 1 - "Open the New Tab page" setting - PASSED

Case 1: - PASSED

Ensure "Open the New Tab page" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 6	Step 9

Case 2: - PASSED

Ensure "Open the New Tab page" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 7

Case 3: - PASSED

Install slightly old version which will want to update. (I used 1.50.86)
Ensure "Open the New Tab page" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Navigate to brave://settings/help and apply update via "Relaunch" button, browser should restart automatically.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step1	Step 2	Step 4	Step 9

Regression set 2 - "Open a specific page or set of pages" setting - PASSED

Case 1: PASSED

Ensure "Open a specific page or set of pages" is enabled (have at least one page configured like brave.com)
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 8	Step 9

Case 2: PASSED

Ensure "Open a specific page or set of pages" is enabled (have at least one page configured like brave.com)
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 3	Step 7

Case 3: PASSED

Install slightly old version which will want to update. (I used 1.50.86)
Ensure "Open a specific page or set of pages" is enabled (have at least one page configured like brave.com)
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Navigate to brave://settings/help and apply update via "Relaunch" button, browser should restart automatically.
Expect the session is not restored and the website is not still opened.
Navigate to https://bayden.com/test/sessions/
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has no value.
Confirmed this behaves the same in 1.49.x as well

Step 1	Step 2	Step 4	Step 5	Step 9

goodov · 2023-03-27T08:53:38Z

Test case 5 (disabled feature, old behavior) - FAILED

that's weird. Can you please check brave://version after reopening that --disable-features parameter is there?

this is what I got:

vBKXxaCsSt.mp4

Regression set 1 - "Open the New Tab page" - FAILED setting
Regression set 2 - "Open a specific page or set of pages" setting - FAILED

The failed regression cases where you use MacOS as a baseline are initially not exactly correct. The browser should restore an old session after a restart triggered by an update no matter what the current restore mode is selected. The reason why the browser doesn't do it on MacOS is because of this.

So this inconsistency with MacOS is currently expected, but we should use Windows version as the baseline in the update-restart test cases. The browser should restore the active session during update-restart no matter what the session restore option is selected. That's the thing we currently miss on MacOS and is visible only when "Continue where you left off" is not selected.

MadhaviSeelam · 2023-03-28T16:09:44Z

@goodov --disable-features parameter is shown in brave://version after relaunching Brave but not seeing expected results as mentioned before. @GeetaSarvadnya seeing same results as me. I have tested in latest nightly (since you tested there) as well and not seeing expected results.

cc: @rebron @kjozwiak

2023-03-28_09h04_06.mp4

goodov · 2023-03-29T11:06:37Z

@goodov --disable-features parameter is shown in brave://version after relaunching Brave but not seeing expected results as mentioned before. @GeetaSarvadnya seeing same results as me. I have tested in latest nightly (since you tested there) as well and not seeing expected results.

cc: @rebron @kjozwiak

Thank you for the video! I've reproduced it, but it's not related to the new feature. For some reason, session cookies set in the very first launch are not preserved on a first restart. This behavior is also exists in the current Release builds (1.49.x) which don't have the new feature we're testing here.

Please rerun the test case, but do a restart before running the test case to ensure that it's not affected by this first run issue.

Please create the issue for this bug in 1.49.x with a description of the session cookie drop after a first restart when "Continue where you left off" is enabled.

GeetaSarvadnya · 2023-04-03T14:32:54Z

Verification PASSED on

Brave	1.50.108 Chromium: 112.0.5615.39 (Official Build) (64-bit) 
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Linux

Verified test plan from #28379 (comment).

Test Case 1 (quit + open) - PASSED

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Open browser.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie has changed to undefined.

Note, confirmed with @goodov that sessionCookie has no value is ok here, the main thing is that this sessionCookie does not say lightcyan.

Step 1	Step 3	Step 6	Step 8

Test case 2 (brave://restart) - PASSED

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Restart the browser via brave://restart.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Step 1	Step 3	Step 5	Step 7

Test case 4 (disabled feature, old behavior) - Encountered #29392

Ensure "Continue where you left off" is enabled.
Open https://bayden.com/test/sessions/ and choose lightcyan from selector.
Ensure sessionCookie says color is: lightcyan.
Fully quit browser.
Launch browser with --disable-features=BraveCleanupSessionCookiesOnSessionRestore.
Expect the session is restored and the website is still opened.
Refresh the page (Ctrl/Cmd+R).
Expect sessionCookie is still lightcyan.

Step 1	Step 3	Step 8

ShivanKaul · 2023-07-18T00:55:32Z

@goodov are session cookies expected to persist between browser restarts on MacOS? I have Continue where you left off turned on in latest Nightly on MacOS, and see that the session cookie persists after a browser restart. I'm using https://bayden.com/test/sessions/ to test.

ShivanKaul · 2023-07-18T00:59:32Z

Screen.Recording.2023-07-17.at.5.58.07.PM.mov

goodov · 2023-07-18T06:58:25Z

@goodov are session cookies expected to persist between browser restarts on MacOS? I have Continue where you left off turned on in latest Nightly on MacOS, and see that the session cookie persists after a browser restart. I'm using https://bayden.com/test/sessions/ to test.

yes. We need to fix the update process on MacOS for this feature to work properly. #25576

ShivanKaul · 2023-07-18T17:24:47Z

That issue deals with the case where there's a pending browser update though right? I don't have a pending browser update. I'm able to repro with Brave Release as well.

LaurenWags · 2023-07-18T17:41:00Z

@ShivanKaul afaik this issue was not implemented on macOS due to the issue I faced in #29135 which I believe is related to what @goodov noted in #28379 (comment).

There was a griffin PR to disable this feature on macOS - brave/brave-variations#557, meaning the old (previous) behavior is expected on macOS, but not Win/Linux.

@goodov please correct me if I am not remembering this correctly.

ShivanKaul · 2023-07-18T17:48:49Z

That's v helpful, thanks @LaurenWags! I've updated this issue's description to make that clearer.

LaurenWags · 2023-07-18T17:50:16Z

good call, thanks @ShivanKaul. We should have clarified what happened previously 👍🏻

goodov · 2023-07-19T05:43:18Z

That issue deals with the case where there's a pending browser update though right? I don't have a pending browser update. I'm able to repro with Brave Release as well.

We don't enable the feature because it breaks the update-restart case where session cookies should be kept.

Geod24 · 2023-07-25T17:38:50Z

I was looking into this change, as it breaks my organisation's use of Brave, and wanted to control it via policy. I found https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy but it seems that this specific setting is not exposed via a policy ?

ShivanKaul · 2023-07-25T17:59:23Z

@Geod24 can you create a new issue? It would be great if you can also mention what platforms you're interested in, and any other details.

goodov added the OS/Desktop label Feb 8, 2023

goodov self-assigned this Feb 8, 2023

goodov mentioned this issue Feb 9, 2023

Add session cookies cleanup on session restore. brave/brave-core#17122

Merged

25 tasks

diracdeltas added the privacy label Feb 14, 2023

goodov closed this as completed in brave/brave-core#17122 Feb 14, 2023

goodov added QA/Yes release-notes/include labels Feb 14, 2023

brave-builds added this to the 1.50.x - Nightly milestone Feb 14, 2023

LaurenWags added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 14, 2023

LaurenWags mentioned this issue Mar 17, 2023

session cookie not persisted on restart when applying browser update - follow up to 28379 #29135

Open

goodov mentioned this issue Mar 17, 2023

WIP: Refactor relaunch process on mac brave/brave-core#15257

Closed

25 tasks

LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 17, 2023

MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 24, 2023

MadhaviSeelam mentioned this issue Mar 29, 2023

Session cookies set in the very first launch are not preserved on a first restart #29392

Open

MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 29, 2023

btlechowski added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 3, 2023

GeetaSarvadnya added the QA Pass-Linux label Apr 3, 2023

LaurenWags mentioned this issue Apr 4, 2023

Desktop Release Notes for 1.50.x - Release #29496

Closed

goodov mentioned this issue Jul 6, 2023

Youtube theater mode not working on browser opening #29591

Closed

ShivanKaul mentioned this issue Jul 19, 2023

Fix youtube theater mode fix script brave/adblock-resources#121

Merged

Geod24 mentioned this issue Jul 25, 2023

Expose a Group Policy to control BraveCleanupSessionCookiesOnSessionRestore #31856

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Session cookies are persisted on session restore #28379

Session cookies are persisted on session restore #28379

goodov commented Feb 8, 2023 •

edited by ShivanKaul

Loading

goodov commented Feb 14, 2023 •

edited by LaurenWags

Loading

LaurenWags commented Mar 16, 2023 •

edited

Loading

goodov commented Mar 17, 2023 •

edited

Loading

MadhaviSeelam commented Mar 24, 2023 •

edited

Loading

goodov commented Mar 27, 2023

MadhaviSeelam commented Mar 28, 2023 •

edited

Loading

goodov commented Mar 29, 2023 •

edited

Loading

GeetaSarvadnya commented Apr 3, 2023 •

edited

Loading

ShivanKaul commented Jul 18, 2023

ShivanKaul commented Jul 18, 2023

goodov commented Jul 18, 2023

ShivanKaul commented Jul 18, 2023

LaurenWags commented Jul 18, 2023 •

edited

Loading

ShivanKaul commented Jul 18, 2023

LaurenWags commented Jul 18, 2023

goodov commented Jul 19, 2023

Geod24 commented Jul 25, 2023

ShivanKaul commented Jul 25, 2023

Session cookies are persisted on session restore #28379

Session cookies are persisted on session restore #28379

Comments

goodov commented Feb 8, 2023 • edited by ShivanKaul Loading

goodov commented Feb 14, 2023 • edited by LaurenWags Loading

Test case 1 (quit+open)

Test case 2 (brave://restart)

Test case 3 (browser update)

Test case 4 (disabled feature, old behavior)

LaurenWags commented Mar 16, 2023 • edited Loading

goodov commented Mar 17, 2023 • edited Loading

MadhaviSeelam commented Mar 24, 2023 • edited Loading

goodov commented Mar 27, 2023

MadhaviSeelam commented Mar 28, 2023 • edited Loading

goodov commented Mar 29, 2023 • edited Loading

GeetaSarvadnya commented Apr 3, 2023 • edited Loading

ShivanKaul commented Jul 18, 2023

ShivanKaul commented Jul 18, 2023

goodov commented Jul 18, 2023

ShivanKaul commented Jul 18, 2023

LaurenWags commented Jul 18, 2023 • edited Loading

ShivanKaul commented Jul 18, 2023

LaurenWags commented Jul 18, 2023

goodov commented Jul 19, 2023

Geod24 commented Jul 25, 2023

ShivanKaul commented Jul 25, 2023

goodov commented Feb 8, 2023 •

edited by ShivanKaul

Loading

goodov commented Feb 14, 2023 •

edited by LaurenWags

Loading

LaurenWags commented Mar 16, 2023 •

edited

Loading

goodov commented Mar 17, 2023 •

edited

Loading

MadhaviSeelam commented Mar 24, 2023 •

edited

Loading

MadhaviSeelam commented Mar 28, 2023 •

edited

Loading

goodov commented Mar 29, 2023 •

edited

Loading

GeetaSarvadnya commented Apr 3, 2023 •

edited

Loading

LaurenWags commented Jul 18, 2023 •

edited

Loading