Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Power section to System in Settings UI #28615

Closed
simonhong opened this issue Feb 20, 2023 · 2 comments · Fixed by brave/brave-core#17290
Closed

Add Power section to System in Settings UI #28615

simonhong opened this issue Feb 20, 2023 · 2 comments · Fixed by brave/brave-core#17290
Assignees
Labels

Comments

@simonhong
Copy link
Member

simonhong commented Feb 20, 2023

STR

  1. Load brave://settings
  2. Check System section has Performance part (Memory saver is off by default)
  3. Check it has Power part when device has battery (First option is selected by default)
  4. Go to app menu -> More tools and click Performance and check brave://settings/system page is loaded
@simonhong simonhong self-assigned this Feb 20, 2023
@simonhong simonhong changed the title Enable Performance section in settings UI Add Power part in System section in Settings UI Feb 20, 2023
simonhong added a commit to brave/brave-core that referenced this issue Feb 24, 2023
fix brave/brave-browser#28615

* kBatterySaverModeAvailable
* kHighEfficiencyModeAvailable

Deleted brave://settings/performance route.
brave://settings/system page has performance section.
Battery setting is only visible when device has battery.
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 25, 2023
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 27, 2023
@rebron rebron changed the title Add Power part in System section in Settings UI Add Power section to System in Settings UI Mar 6, 2023
@LaurenWags
Copy link
Member

cc @kjozwiak to take a look at this one on his Win 11 laptop

@stephendonner
Copy link

stephendonner commented Mar 24, 2023

Verification PASSED using

Brave 1.50.101 Chromium: 111.0.5563.116 (Official Build) beta (64-bit)
Revision ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS Windows 10 Version 22H2 (Build 19045.2728)

Shared Steps:

  1. installed 1.50.101
  2. launched Brave
  3. clicked on the app menu
  4. clicked on More Tools
  5. clicked on Performance
  6. confirmed it opened brave://settings/system

Performance

Memory Saver

  • Confirmed Memory Saver is toggled to Off by default
  • Confirmed Learn more link goes to staged How do I use the memory saver feature in Brave? support article, at https://support.brave.com/hc/en-us/articles/13383683902733
default Learn more toggled to On
image image image

Always keep these sites active

Confirmed ability to:

  • Add
  • Edit
  • Remove
default Add Edit Remove
image image image image

Power

Energy Saver

  • Confirmed Energy Saver is toggled to On by default, on my Dell XPS laptop
  • Confirmed Learn more link goes to staged How do I use the Memory Saver feature in Brave? support article, at https://support.brave.com/hc/en-us/articles/13383683902733-How-do-I-use-the-Memory-Saver-feature-in-Brave-

Turn on only when my battery is at 20% or lower

Steps:

(continued from Shared Steps, above)

  1. clicked on the Turn on only when my battery is at 20% or lower radio button
  2. dwindled my Dell XPS laptop's battery to 18%
  3. confirmed I saw the Energy Saver mode is on icon

Turn on when my computer is unplugged

Steps:

(continued from Shared Steps, above)

  1. clicked on the Turn on when my computer is unplugged radio button
  2. unplugged my power cable
  3. confirmed I saw the Energy Saver mode is on icon
default Learn more Turn on when...unplugged battery < 20% disabled
image image image image image

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants