Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UGP support #288

Closed
bbondy opened this issue Jun 6, 2018 · 3 comments · Fixed by brave/brave-core#241
Closed

UGP support #288

bbondy opened this issue Jun 6, 2018 · 3 comments · Fixed by brave/brave-core#241

Comments

@bbondy
Copy link
Member

bbondy commented Jun 6, 2018

We'll want to add support to Brave Core for giving users grants from our User Growth Pool (UGP)

This is a server-side configured promotion which the browser will check for and prompt the user to engage in. Here are a few screen caps from browser-laptop:
screen shot 2018-06-17 at 10 02 39 pm
screen shot 2018-06-17 at 10 02 47 pm

Promotion is currently checked for using the BAT client's getPromotion method:
https://github.com/brave-intl/bat-client/blob/9c5cb329c2e007bc8ad9a69ffa59d98d95407b37/index.js#L757

Basically the grants are fetched and have an expiration date (controlled server side). The BAT client library conveniently wraps calls to the REST service on the backend.

With browser-laptop, we have a captcha in place which must be solved before a user can claim the grant:
screen shot 2018-06-17 at 10 10 02 pm

@LaurenWags
Copy link
Member

@NejcZdovc is testing done for this #928 (comment) sufficient to cover this issue? if not, could you suggest additional test cases? cc @kjozwiak

@NejcZdovc
Copy link
Contributor

@LaurenWags yes, that should be sufficient

@LaurenWags LaurenWags added QA/No and removed QA/Yes labels Oct 4, 2018
@LaurenWags
Copy link
Member

Labelling as QA/No as this was basically tested under #928 (comment) as confirmed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants