Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captcha image #928

Closed
NejcZdovc opened this issue Sep 2, 2018 · 1 comment · Fixed by brave/brave-core#479
Closed

Captcha image #928

NejcZdovc opened this issue Sep 2, 2018 · 1 comment · Fixed by brave/brave-core#479

Comments

@NejcZdovc
Copy link
Contributor

Captcha image that we currently use in rewards is from browser laptop, which is of course wrong. We need new api call that will return adjusted image for brave-core. This will live in /v3/captchas/{paymentId}

Current
image

@kjozwiak
Copy link
Member

kjozwiak commented Oct 3, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

screen shot 2018-10-03 at 5 18 57 pm

  • Verified that you can claim a grant after failing several times
  • Verified that you cannot claim a grant when failing the CAPTCHA by failing the solution
  • Verified that you cannot claim a grant when dropping the BAT icon in blank spaces
  • Verified that you can claim the grant if you initially cancel the CAPCHA by clicking in X
  • Verified that you can claim the grant when closing chrome://rewards while CAPTCHA is still opened

Verified passed with macOS 10.12.6 x64

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • Verified that you can claim a grant after failing several times
  • Verified that you cannot claim a grant when failing the CAPTCHA by failing the solution
  • Verified that you cannot claim a grant when dropping the BAT icon in blank spaces
  • Verified that you can claim the grant if you initially cancel the CAPCHA by clicking in X
  • Verified that you can claim the grant when closing chrome://rewards while CAPTCHA is still opened

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified incorrect dnd doesn't claim the grant
  • Verified grant can be claimed after several wrong attempts
  • Verified dnd on empty area doesn't claim the grant
  • Verified dnd on correct target claims the grant at the first attempt
  • Verified several wrong attempts and close CAPTCHA and subsequent attempt claims the grant
  • Verified closing chrome://rewards and reopening doesnt retain the CAPTCHA modal open
  • Verified that you can claim the grant after closing the CAPTCHA modal and reopening it

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants