Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News articles opened in new tab always get grouped #28868

Closed
Uni-verse opened this issue Mar 2, 2023 · 1 comment · Fixed by brave/brave-core#18345
Closed

News articles opened in new tab always get grouped #28868

Uni-verse opened this issue Mar 2, 2023 · 1 comment · Fixed by brave/brave-core#18345
Assignees
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@Uni-verse
Copy link
Contributor

Description

After disabling tab groups, news articles always open in grouped tabs.

Steps to reproduce

  1. Install 1.49
  2. Enable news
  3. Long press on an article on NTP and open in new tab
  4. Now disable tab groups, restart app
  5. long press on an article on NTP and open in new tab

Actual result

Tabs are grouped

Expected result

Should not be grouped

Example Example
screenshot-1677790234039 screenshot-1677790320853

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? N/A
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: 13

Brave version

1.49.117, Chromium 111.0.5563.50

@hffvld
Copy link
Contributor

hffvld commented Jun 9, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB2.230407.019 release-keys]
Brave build: 1.53.83
Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
Revision: 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}

STEPS:

  1. Launch Brave
  2. NTP > Show Brave News
  3. Tap and hold on an article on NTP News > Open in New Tab > Verify
  4. Three-dot Menu > Settings > Appearance > Set Only open links in current tab group to OFF
  5. On NTP News tap and hold on an article > Open in New Tab > Verify

ACTUAL RESULTS:

  • Verified that news articles opened in the current tab group when Only open links in current tab group set to ON
  • Verified that news articles opened in the new tab when Only open links in current tab group set to OFF
timestamp_15-35-55_15-36-57.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants