Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] brave news open article on new tab based on tab groups #18345

Merged
merged 1 commit into from
May 5, 2023

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#28868

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable news
  2. Long press on an article on NTP and open in new tab. It will open the article in background in the same tab group
  3. Now disable tab groups, restart app
  4. Long press on an article on NTP and open in new tab. It will open the article in background in the new tab

@tapanmodh tapanmodh added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 3, 2023
@tapanmodh tapanmodh added this to the 1.53.x - Nightly milestone May 3, 2023
@tapanmodh tapanmodh self-assigned this May 3, 2023
@@ -214,9 +215,14 @@ public static void openUrlInNewTabInBackground(boolean isIncognito, String url)
BraveActivity braveActivity = BraveActivity.getBraveActivity();
if (braveActivity.getTabModelSelector() != null
&& braveActivity.getActivityTab() != null) {
int tabLaunchType;
if (BraveTabUiFeatureUtilities.isBraveTabGroupsEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use turnary operator here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion. I'll use it

@tapanmodh tapanmodh requested a review from deeppandya May 5, 2023 04:28
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapanmodh tapanmodh force-pushed the fix_news_article_open_grouped branch from 30bbdf4 to 65a115c Compare May 5, 2023 07:52
@tapanmodh tapanmodh merged commit b6eca0c into master May 5, 2023
@tapanmodh tapanmodh deleted the fix_news_article_open_grouped branch May 5, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News articles opened in new tab always get grouped
3 participants