Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add way to close or cancel from 'Choose Device Type dialog' #2904

Closed
rebron opened this issue Jan 10, 2019 · 1 comment · Fixed by brave/brave-core#4405
Closed

add way to close or cancel from 'Choose Device Type dialog' #2904

rebron opened this issue Jan 10, 2019 · 1 comment · Fixed by brave/brave-core#4405
Labels
feature/sync priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Milestone
Closed / Dupe / I...

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 10, 2019 •
edited
Loading

Description

screen shot 2019-01-09 at 2 53 06 pm

A user has to choose Phone/Tablet or Computer to proceed and may want to cancel out of this process all together. Need a method to close out of this dialog and go back to previous screen. An "x" button, top right corner may suffice and consistent with other UI.
@rebron rebron added the design A design change, especially one which needs input from the design team label Jan 10, 2019
@bbondy bbondy added this to the 1.x Backlog milestone Jan 13, 2019
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed design A design change, especially one which needs input from the design team labels Jan 15, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@rossmoody rossmoody removed their assignment Aug 13, 2019
@btlechowski
Copy link

Still reproducible

image

Brave 1.5.46 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

cc @cezaraugusto @jsecretan

@btlechowski btlechowski mentioned this issue Jan 21, 2020
Merged
@cezaraugusto cezaraugusto self-assigned this Jan 22, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 22, 2020
@cezaraugusto
Sync: Add close button to Choose Device Type modal
6490928 
Fix brave/brave-browser#2904
@cezaraugusto cezaraugusto mentioned this issue Jan 22, 2020
Merged
32 tasks
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/sync priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

Sync: Add close button to Choose Device Type modal brave/brave-core
5 participants
@bbondy @cezaraugusto @rebron @rossmoody @btlechowski