-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reminder notification: If user clicks same ad 3 times, then show reminder notification that clicking is not necessary to earn #29313
Comments
@Miyayes could you add appropriate "QA" label ( |
Verification passed on
Reminder notification after single notification ad - PASS
Verified got the reminder notification Clicking Reminder notification - FAIL
Clicking Reminder Notification yields no action, logged #30281 Reminder notification after single Brave News inline ad - FAIL
Failed to get reminder notification, logged #30280 Reminder notification after single ntp-si ad - FAIL
Failed to get reminder notification, logged #30280 Reminder notification after browser restart - PASS
Verified got the reminder notification |
Added QA/Test-All-Platforms. Please test only |
Verification
|
Brave | 1.52.103 Chromium: 113.0.5672.126 (Official Build) beta (x86_64) |
---|---|
Revision | c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202} |
OS | macOS Version 13.4 (Build 22F66) |
Reminder notification after single notification ad - PASSED
Steps:
- installed
1.52.103
- launched Brave using
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
- enabled Rewards and Ads
- viewed a notification ad
- clicked the notification ad
Confirmed clicking on the 1st ad notification yielded You earn when a Brave ads notifi...
notification
Also confirmed the notification's link is https://support.brave.com/hc/en-us/articles/14648356808845
example | example | example | example | example |
---|---|---|---|---|
Verification passed on
Reminder notification after single notification ad - PASS
Verified got the reminder notification Clicking Reminder notification - PASS |
Description
If user clicks same ad 3 times, then show reminder notification that clicking is not necessary to earn:
cc: @ddvorin1 @tmancey
The text was updated successfully, but these errors were encountered: