Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reminder notification: If user clicks same ad 3 times, then show reminder notification that clicking is not necessary to earn #29313

Closed
Miyayes opened this issue Mar 25, 2023 · 5 comments · Fixed by brave/brave-core#17966

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 25, 2023

Description

If user clicks same ad 3 times, then show reminder notification that clicking is not necessary to earn:

Reminder: You earn when a Brave Ads notification appears.
You don’t need to click to earn, but do click if you’re interested!

cc: @ddvorin1 @tmancey

@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 29, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 13, 2023
@LaurenWags
Copy link
Member

@Miyayes could you add appropriate "QA" label (QA/Yes or QA/No) and appropriate release notes label (release-notes/include or release-notes/exclude)? Thanks!

@btlechowski
Copy link

btlechowski commented May 11, 2023

Verification passed on

Brave 1.52.93 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Ubuntu 18.04 LTS

Reminder notification after single notification ad - PASS

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View a notification ad
  3. Click notification ad

Verified got the reminder notification

image

Clicking Reminder notification - FAIL

  1. Continue from Reminder notification after single notification ad
  2. Click Reminder Notification

Clicking Reminder Notification yields no action, logged #30281

Reminder notification after single Brave News inline ad - FAIL

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View a inline ad

Failed to get reminder notification, logged #30280

Reminder notification after single ntp-si ad - FAIL

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View a ntp-si ad

Failed to get reminder notification, logged #30280

Reminder notification after browser restart - PASS

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/2 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View and click notification ad
  3. Restart Browser
  4. View and click notification ad

Verified got the reminder notification

image

@btlechowski
Copy link

Added QA/Test-All-Platforms.

Please test only Reminder notification after single notification ad from #29313 (comment)

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 19, 2023
@stephendonner
Copy link

stephendonner commented May 19, 2023

Verification PASSED using

Brave 1.52.103 Chromium: 113.0.5672.126 (Official Build) beta (x86_64)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS macOS Version 13.4 (Build 22F66)

Reminder notification after single notification ad - PASSED

Steps:

  1. installed 1.52.103
  2. launched Brave using
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. enabled Rewards and Ads
  2. viewed a notification ad
  3. clicked the notification ad

Confirmed clicking on the 1st ad notification yielded You earn when a Brave ads notifi... notification

Also confirmed the notification's link is https://support.brave.com/hc/en-us/articles/14648356808845

example example example example example
Screenshot 2023-05-19 at 11 04 06 AM Screenshot 2023-05-19 at 11 04 10 AM Screenshot 2023-05-19 at 11 04 20 AM Screenshot 2023-05-19 at 11 04 49 AM Screenshot 2023-05-19 at 11 04 57 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 19, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 23, 2023

Verification passed on

Brave 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Windows 10 Version 22H2 (Build 19045.2965)

Reminder notification after single notification ad - PASS

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View a notification ad
  3. Click notification ad

Verified got the reminder notification

image

Clicking Reminder notification - PASS

  1. Continue from Reminder notification after single notification ad
  2. Click Reminder Notification

image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 23, 2023
@btlechowski btlechowski added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants