Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Policy - expose a way to disable Brave VPN #29397

Closed
bsclifton opened this issue Mar 29, 2023 · 5 comments · Fixed by brave/brave-core#17836
Closed

Group Policy - expose a way to disable Brave VPN #29397

bsclifton opened this issue Mar 29, 2023 · 5 comments · Fixed by brave/brave-core#17836

Comments

@bsclifton
Copy link
Member

Description

Originally reported here:
#26502 (comment)

Brave should have a new option to disable Brave VPN. BraveVPNDisabled - with 0 being default (enabled) and 1 being disabled

See https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy for existing group policies

Opens

Should this cover Android also? Android does support group policy. If it's easy enough, we can consider doing this for Android too (if so, add the OS/Android label)

@stephendonner
Copy link

stephendonner commented May 4, 2023

@brave/qa-team: removed QA/Test-All-Platforms (technically not Linux, until we implement Wireguard support), but added OS/macOS and OS/Windows labels, since group policies need to be set differently, obviously, via macOS and Windows.

@stephendonner
Copy link

stephendonner commented May 9, 2023

Verification PASSED using

Brave 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (x86_64)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS macOS Version 11.7.6 (Build 20G1231)

Case 1: Defaults

Steps:

  1. installed 1.52.92
  2. launched Brave
  3. loaded brave://flags
  4. clicked on the VPN button in the toolbar
  5. loaded brave://policy
  6. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • clicking on the VPN button opens the Buy / Already purchased...? dialog
  • no active browser-management policies
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)
brave://flags Buy dialog brave://policy brave://version
Screen Shot 2023-05-09 at 1 03 26 PM Screen Shot 2023-05-09 at 1 03 31 PM Screen Shot 2023-05-09 at 1 03 49 PM Screen Shot 2023-05-09 at 1 04 44 PM

Case 2: Enabling BraveVPNDisabled policy - PASSED*

Steps:

  1. installed 1.52.92
  2. ran defaults write com.brave.Browser.beta BraveVPNDisabled -bool true in Terminal/console
  3. launched Brave
  4. loaded brave://flags
  5. loaded brave://policy
  6. loaded brave://version

Confirmed:

brave://flags brave://policy brave://version
Screen Shot 2023-05-09 at 1 55 32 PM Screen Shot 2023-05-09 at 12 46 25 PM Screen Shot 2023-05-09 at 1 56 17 PM

Case 3: Disabling BraveVPNDisabled policy - PASSED

Steps:

(continued from Enabling BraveVPNDisabled Policy

  1. ran defaults write com.brave.Browser.beta BraveVPNDisabled -bool false in Terminal/console
  2. launched Brave
  3. loaded brave://flags
  4. loaded brave://policy
  5. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • the VPN button is present on the toolbar
  • top-level Brave VPN menu item is present
  • clicking either of the above opens the Buy/Already purchased...? dialog
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study; mentioned only for completeness)
brave://flags VPN button / Buy dialog Brave VPN menu item brave://policy brave://version
Screen Shot 2023-05-09 at 3 10 57 PM Screen Shot 2023-05-09 at 3 12 41 PM Screen Shot 2023-05-09 at 3 12 37 PM Screen Shot 2023-05-09 at 3 11 01 PM Screen Shot 2023-05-09 at 3 11 10 PM

Case 4: Removing BraveVPNDisabled policy completely - PASSED

Steps:

  1. ran defaults delete com.brave.Browser.beta BraveVPNDisabled in Terminal
  2. launched Brave
  3. opened brave://flags
  4. opened brave://policy
  5. opened brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • clicking on the VPN button opens the Buy / Already purchased...? dialog
  • no active browser-management policies listed in brave://policy
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)
brave://flags Brave VPN button / Buy dialog Brave VPN menu item brave://policy brave://version
Screen Shot 2023-05-09 at 3 21 34 PM Screen Shot 2023-05-09 at 3 21 57 PM Screen Shot 2023-05-09 at 3 22 02 PM Screen Shot 2023-05-09 at 3 21 38 PM Screen Shot 2023-05-09 at 3 21 48 PM

(*) Logged:

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 9, 2023
@stephendonner stephendonner added QA Pass-macOS QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 9, 2023
@stephendonner
Copy link

stephendonner commented May 10, 2023

Verification PASSED using

Brave 1.52.93 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Windows 10 Version 22H2 (Build 19045.2965)

Case 1: Defaults

Steps:

  1. installed 1.52.92
  2. launched Brave
  3. loaded brave://flags
  4. clicked on the VPN button in the toolbar
  5. loaded brave://policy
  6. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • clicking on the VPN button opens the Buy / Already purchased...? dialog
  • no active browser-management policies
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)
brave://flags VPN button/Buy dialog Brave VPN menu item brave://policy brave://version
image image image image image

Case 2: Enabling BraveVPNDisabled policy - PASSED

Steps:

  1. installed 1.52.93
  2. launched Local Group Policy Editor, and added an entry for Brave, per https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy
  3. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave
  4. launched Brave
  5. loaded brave://flags
  6. loaded brave://settings/appearance
  7. loaded brave://policy
  8. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • the VPN button has been removed/hidden
  • top-level Brave VPN menu item is removed/hidden
  • no Show VPN button toggle in brave://settings/appearance
  • brave://policy shows BraveVPNDisabled set to true
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)
brave://flags Local policy editor Windows registry No BraveVPN menu item/button brave://settings/appearance brave://policy brave://version
image image image (4) image image image (5) image

Case 3: Disabling BraveVPNDisabled policy - PASSED

Steps:

(continued from Enabling BraveVPNDisabled Policy

  1. opened Registry Editor
  2. set BraveVPNDisabled in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave to 0
  3. launched Brave
  4. loaded brave://flags
  5. loaded brave://settings/appearance
  6. loaded brave://policy
  7. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • the VPN button is present on the toolbar
  • top-level Brave VPN menu item is present
  • Show VPN button toggle is present in brave://settings/appearance
  • clicking either of the above opens the Buy/Already purchased...? dialog
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study; mentioned only for completeness)
brave://flags Windows registry VPN button / Buy dialog Brave VPN menu item brave://settings/appearance brave://policy brave://version
image image image image image (6) image image

Case 4: Removing BraveVPNDisabled policy completely - PASSED

Steps:

(continued from Disabling BraveVPNDisabled Policy

Steps:

  1. opened Registry Editor
  2. context-clicked on BraveVPNDisabled in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave
  3. chose Delete
  4. clicked Yes in the next dialog
  5. opened brave://flags
  6. opened brave://settings/appearance
  7. opened brave://policy
  8. opened brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • clicking on the VPN button opens the Buy / Already purchased...? dialog
  • Show VPN button toggle is present in brave://settings/appearance
  • no active browser-management policies listed in brave://policy
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)

Windows registry

example example
image image
brave://flags Brave VPN button / Buy dialog Brave VPN menu item brave://settings/appearance brave://policy brave://version
image image image image (6) image image

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 10, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 19, 2023

Verification PASSED using

Brave | 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
-- | --
Revision | c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Case 1: Defaults

Steps:

  1. installed 1.52.102
  2. launched Brave
  3. loaded brave://flags
  4. clicked on the VPN button in the toolbar
  5. loaded brave://policy
  6. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • clicking on the VPN button opens the Buy / Already purchased...? dialog
  • no active browser-management policies
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)
brave://flags VPN button/Buy dialog Brave VPN menu item brave://policy brave://version
image image image image image

Testcase 1: Not subscribed to VPN

Case 1: Enabling BraveVPNDisabled policy - PASSED

Steps:

  1. installed 1.52.102
  2. launched Local Group Policy Editor, and added an entry for Brave, per https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy
  3. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave
  4. launched Brave
  5. loaded brave://flags
  6. loaded brave://settings/appearance
  7. loaded brave://policy
  8. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • the VPN button has been removed/hidden
  • top-level Brave VPN menu item is removed/hidden
  • no Show VPN button toggle in brave://settings/appearance
  • brave://policy shows BraveVPNDisabled set to true
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)
  • confirmed Your browser is managed(browser://management/) by your organization message is shown in brave://settings/appearance
brave://flags Local policy editor Windows registry No BraveVPN menu item/button brave://settings/appearance brave://policy brave://version
image image image image image image image

Case 2: Disabling BraveVPNDisabled policy - PASSED

Steps:

(continued from n Case 2: Enabling BraveVPNDisabled Policy

  1. opened Registry Editor
  2. set BraveVPNDisabled in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave to 0
  3. launched Brave
  4. loaded brave://flags
  5. loaded brave://settings/appearance
  6. loaded brave://policy
  7. loaded brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • the VPN button is present on the toolbar
  • top-level Brave VPN menu item is present
  • Show VPN button toggle is present in brave://settings/appearance
  • clicking either of the above opens the Buy/Already purchased...? dialog
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study; mentioned only for completeness)
brave://flags Windows registry VPN button / Buy dialog Brave VPN menu item brave://settings/appearance brave://policy brave://version
image image image image image image image

Case 3: Removing BraveVPNDisabled policy completely - PASSED

Steps:

(continued from Case 3 Disabling BraveVPNDisabled Policy

Steps:

  1. opened Registry Editor
  2. context-clicked on BraveVPNDisabled in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave
  3. chose Delete
  4. clicked Yes in the next dialog
  5. opened brave://flags
  6. opened brave://settings/appearance
  7. opened brave://policy
  8. opened brave://version

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • clicking on the VPN button opens the Buy / Already purchased...? dialog
  • Show VPN button toggle is present in brave://settings/appearance
  • no active browser-management policies listed in brave://policy
  • enrolled in CrossPlatformVPNStudy:Enabled (Griffin study)

Windows registry

example example example
image image image
brave://flags Brave VPN button / Buy dialog Brave VPN menu item brave://settings/appearance brave://policy brave://version
image image image image image image

Test case 2: Subscribed to VPN

Case 1: Disabled BraveVPNDisabled policy and purchased VPN (but not connected) - PASSED

  1. new profile
  2. launched Local Group Policy Editor, and added an entry for Brave, per https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy
  3. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave and set value to 0
  4. launched Brave
  5. loaded brave://flags
  6. loaded brave://settings/appearance
  7. loaded brave://policy
  8. loaded brave://version
  9. purchased VPN but not connected (account.bravesoftware.com)

Confirmed:

  • brave://flags/#brave-vpn is set to default
  • the VPN button is present on the toolbar
  • Show VPN button toggle is present in brave://settings/appearance and Your browser is managed (brave://management/) by your organization
  • successfully subscribed to VPN but VPN is not enabled (yet)
  • brave://policy shows BraveVPNDisabled set to false
step 2 step 3 step 5 step 6 step 7 step 8
image image image image image image

Case 2: Disabled BraveVPNDisabled policy and connected to VPN - PASSED

  1. continuing from Case 1:
    • VPN is not connected in the VPN panel
    • BraveVPNDisabled policy shows false in brave://policy
  2. enabled VPN in the VPN panel

Confirmed:

  • VPN toggle is in connected state
  • top-level Brave VPN menu item is present with flyout menu in connected state and with text managed by your organization
  • brave://policy shows BraveVPNDisabled set to false
example example example example
image image image image

Case 3: Disabled BraveVPNDisabled policy and VPN is disconnected - PASSED

  1. continuing from Case 2:
    • VPN is connected in the VPN panel
    • BraveVPNDisabled policy shows false in brave://policy
  2. disconnected VPN in the VPN panel

###Confirmed:

  • VPN toggle is in disconnected state
  • top-level Brave VPN menu item is present with flyout menu in disconnected state and with text managed by your organization
  • brave://policy shows BraveVPNDisabled set to false
example example example example
image image image image

Case 4: Enabled BraveVPNDisabled policy while VPN is connected - PASSED

  1. new profile
  2. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave and set value to 0
  3. purchase VPN and connect to VPN in the VPN panel
  4. connected to VPN via hamburger menu->Brave VPN->Brave VPN
  5. verified brave://policy is shown false
  6. close the browser
  7. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave and set value to 1
  8. relaunch Brave

Confirmed:

  • the VPN button has been removed/hidden
  • top-level Brave VPN menu item is removed/hidden
  • no Show VPN button toggle in brave://settings/appearance
  • brave://policy shows BraveVPNDisabled set to true
  • confirmed Your browser is managed(browser://management/) by your organization message is shown in brave://settings/appearance
example example example example example example example example
image image image image image image image image

Case 5: Enabled BraveVPNDisabled policy while VPN is disconnected - PASSED

  1. new profile
  2. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave and set value to 0
  3. purchase VPN and connect to VPN in the VPN panel
  4. connected to VPN via hamburger menu->Brave VPN->Brave VPN
  5. verified brave://policy is shown false
  6. close the browser
  7. launched Registry Editor, and added BraveVPNDisabled as a DWORD to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave and set value to 1
  8. relaunch Brave

Confirmed:

  • the VPN button has been removed/hidden
  • top-level Brave VPN menu item is removed/hidden
  • no Show VPN button toggle in brave://settings/appearance
  • brave://policy shows BraveVPNDisabled set to true
  • confirmed Your browser is managed(browser://management/) by your organization message is shown in brave://settings/appearance
example example example example example example example
image image image image image image image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 19, 2023
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2023
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 30, 2023
@bsclifton bsclifton removed the OS/Android Fixes related to Android browser functionality label May 30, 2023
@bsclifton
Copy link
Member Author

Removed OS/Android label because disabling group policy doesn't turn off in-app-purchases (will disable the render frame observer code, used for linking receipt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants