Brave VPN top-level menu item should be removed/hidden, when BraveVPNDisabled is true

[stephendonner]

Description

Brave VPN top-level menu item should be removed/hidden, when BraveVPNDisabled is true

Found while testing #29397.

Steps to Reproduce

1. install 1.52.92
2. ran defaults write com.brave.Browser.beta BraveVPNDisabled -bool true in my Terminal
3. launch Brave
4. note the VPN button is missing on the toolbar, as expected
5. click on the top-level application menu
6. see/choose Brave VPN

Actual result:

The Brave VPN menu item should be removed, when the BraveVPNDisabled policy is set to true

example	example

Expected result:

No Brave VPN menu item in the top-level app menu

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @bsclifton @spylogsster @simonhong @MadhaviSeelam

[stephendonner]

(Note: to remove the policy completely, run defaults delete com.brave.Browser.beta BraveVPNDisabled.)

[simonhong]

I suspect that PrefService::IsManagedPreference(prefs::kManagedBraveVPNDisabled) gives false on macOS.
but prefs->GetBoolean(prefs::kManagedBraveVPNDisabled) gives true when policy is set by above command.
Windows doesn't have this issue.

Not sure it's related or not but it's recommended level on macOS. It's mandatory on Wndows.

[stephendonner]

Ah, yes, we've run into a variant of this before (IIRC, with the New Private Window with Tor menu item(s) 👍

[kjozwiak]

The above requires 1.52.101 or higher for 1.52.x verification 👍

[stephendonner]

Verified PASSED using

Brave	1.52.101 Chromium: 113.0.5672.92 (Official Build) beta (x86_64)
Revision	b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS	macOS Version 11.7.6 (Build 20G1231)

Followed my original steps to reproduce in #30239 (comment).

Confirmed VPN browser-toolbar button and Brave VPN top-level menu item are hidden

example	example