Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default ethereum/solana setting P3A metrics #29712

Closed
DJAndries opened this issue Apr 13, 2023 · 2 comments · Fixed by brave/brave-core#18059
Closed

Remove default ethereum/solana setting P3A metrics #29712

DJAndries opened this issue Apr 13, 2023 · 2 comments · Fixed by brave/brave-core#18059
Assignees
@DJAndries
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.52.x - Release

Comments

@DJAndries
Copy link
Collaborator

Remove Brave.Wallet.DefaultWalletSetting and Brave.Wallet.DefaultSolanaWalletSetting metrics, since Brave.Wallet.EthProvider.3 and Brave.Wallet.SolProvider are successors.
@DJAndries DJAndries added OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 13, 2023
@DJAndries DJAndries self-assigned this Apr 13, 2023
@DJAndries DJAndries mentioned this issue Apr 13, 2023
Merged
25 tasks
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Apr 18, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 18, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 9, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 10 Version 21H2 (Build 19044.2846)
The metrics are removed from 1.52.x
  • Confirmed that the metrics Brave.Wallet.DefaultWalletSetting and Brave.Wallet.DefaultSolanaWalletSetting are removed from the brave://local-state file
1.51.x 1.52.x 1.52.x
image image image

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 9, 2023
@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 11, 2023
Closed
@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 11, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 29, 2023 •
edited
Loading

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.52.112

  • There is no default provider option for Android so only checking the following which is applicable.
  • Confirmed that the metrics Brave.Wallet.DefaultWalletSetting and Brave.Wallet.DefaultSolanaWalletSetting are removed from the brave://local-state file
1.51.x 1.52.x 1.52.x
Screenshot_20230529_173316 Screenshot_20230529_172307 Screenshot_20230529_172332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Remove default wallet setting P3A metrics brave/brave-core
3 participants
@DJAndries @GeetaSarvadnya @brave-builds