Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CTA on desktop VPN modal #29838

Closed
rmcfadden3 opened this issue Apr 18, 2023 · 4 comments · Fixed by brave/brave-core#18524
Closed

Adjust CTA on desktop VPN modal #29838

rmcfadden3 opened this issue Apr 18, 2023 · 4 comments · Fixed by brave/brave-core#18524
Assignees
Labels
feature/vpn l10n needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rmcfadden3
Copy link

Description

Per this Slack thread, we'd like to adjust the CTA on the desktop VPN modal (currently, this button just says "Buy") to instead say "Start free trial" … or we could just do "Start trial" if "Start free trial" is too many characters.

CC @mattmcalister @vinny-brave @rebron @bsclifton

Steps to Reproduce

  1. Open Brave
  2. Click "VPN" pill in address bar
  3. See "Buy" button in this modal

Expected result:

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. needs-text-change This change requires some careful wording. l10n release-notes/exclude labels May 2, 2023
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 18, 2023
@simonhong simonhong self-assigned this May 18, 2023
simonhong added a commit to brave/brave-core that referenced this issue May 18, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 18, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.53.52 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Windows 10 Version 22H2 (Build 19045.2965)

Steps:

  1. installed 1.53.52
  2. launched Brave
  3. clicked on the VPN button on the browser toolbar

Confirmed it now reads Start free trial, rather than Buy

example example
image image (1)

@kjozwiak
Copy link
Member

The above needs to be re-verified due to brave/brave-core#18524 being uplifted into 1.52.x via brave/brave-core#18573. Used #29838 (comment) as the needed verification on Nightly to uplift into 1.52.x as per brave/brave-core#18573 (review).

@kjozwiak
Copy link
Member

The above requires 1.52.110 or higher for 1.52.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit)
Revision 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS Windows 10 Version 22H2 (Build 19045.2965)

Steps:

  1. installed 1.52.112
  2. launched Brave
  3. clicked on the VPN button in the browser toolbar

Confirmed the text change of the button label to Start free trial, from the stark Buy

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn l10n needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants