Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resurrect context menu to switching tab strip orientation #29939

Closed
sangwoo108 opened this issue Apr 22, 2023 · 2 comments · Fixed by brave/brave-core#18207
Closed

Resurrect context menu to switching tab strip orientation #29939

sangwoo108 opened this issue Apr 22, 2023 · 2 comments · Fixed by brave/brave-core#18207
Assignees
@sangwoo108
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@sangwoo108
Copy link

image

As per the latest design, we should leave "Use vertical tabs" context menu.
@sangwoo108 sangwoo108 self-assigned this Apr 22, 2023
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Apr 22, 2023
This was referenced Apr 24, 2023
Merged
Merged
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 25, 2023
@kjozwiak
Copy link
Member

The above requires 1.51.106 or higher for 1.51.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 27, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.51.106 Chromium: 113.0.5672.53 (Official Build) (64-bit)
-- | --
Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS | Windows 11 Version 22H2 (Build 22621.1555)
  1. Installed 1.51.106
  2. launch Brave
  3. opened brave://flags
  4. enabled #brave-vertical-tabs
  5. opened a new tab and right clicked to open context menu
  6. selected Use vertical tabs
  • Confirmed Vertical tabs view is shown in expanded mode as default as expected
  • Confirmed all three modes Float on mouseover, Expanded and Minimized mode working as expected
  • Confirmed horizontal tab view shown when unselected Use vertical tabs in the context menu
example example example example
image image image image
Float on mouseover Expanded Minimized
image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Resurrect "Use vertical tabs" Context menu brave/brave-core
4 participants
@kjozwiak @sangwoo108 @brave-builds @MadhaviSeelam