Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect "Use vertical tabs" Context menu #18207

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Resurrect "Use vertical tabs" Context menu #18207

merged 1 commit into from
Apr 25, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Apr 24, 2023

Base on our latest design guide, we need "Use vertical tabs" menu.
This PR partially reverts the previous PR - #18146

Resolves brave/brave-browser#29939

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Enable vertical tabs
  • Click right button on tabs
  • There should be "Use vertical tabs" item and it should work as expected.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings ++

Base on our latest design guide, we need "Use vertical tabs" menu.
@sangwoo108 sangwoo108 enabled auto-merge (squash) April 25, 2023 00:21
@sangwoo108 sangwoo108 merged commit 3b9c681 into master Apr 25, 2023
@sangwoo108 sangwoo108 deleted the sko/vtab-ctxt branch April 25, 2023 10:38
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 25, 2023
@kjozwiak
Copy link
Member

Verification passed on master via #18146 (comment) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resurrect context menu to switching tab strip orientation
4 participants