Build fails checking linux package deps on other distros when --official-build=false #305

bkero · 2018-06-07T18:16:45Z

Description

The build fails while doing the create_dist step with the following logs:

Steps to Reproduce

sudo ./src/build/install-build-deps.sh --no-prompt
yarn build Release --debug_build=false --official_build=false --channel=beta
yarn run create_dist Release --debug_build=false --official_build=false --channel=beta

Actual result:

01:00:26 [607/644] STAMP obj/chrome/installer/linux/calculate_rpm_dependencies.inputdeps.stamp
01:00:26 [608/644] STAMP obj/chrome/installer/linux/calculate_deb_dependencies.inputdeps.stamp
01:00:26 [609/644] ACTION //chrome/installer/linux:calculate_rpm_dependencies(//build/toolchain/linux:clang_x64)
01:00:26 [610/644] ACTION //chrome/installer/linux:calculate_rpm_dependencies(//build/toolchain/linux:clang_x64)
01:00:26 FAILED: rpm_brave.deps 
01:00:26 python ../../chrome/installer/linux/rpm/calculate_package_deps.py brave rpm_brave.deps --distro-check
01:00:26 Unexpected new dependency libresolv.so.2()(64bit) on distro openSUSE Leap 42.3 caused by binary brave
01:00:26 Unexpected new dependency libcairo-gobject.so.2()(64bit) on distro openSUSE Leap 42.3 caused by binary brave
01:00:26 Unexpected new dependency libplc4.so()(64bit) on distro openSUSE Leap 42.3 caused by binary brave
01:00:26 Unexpected new dependency libz.so.1()(64bit) on distro openSUSE Leap 42.3 caused by binary brave
01:00:26 Unexpected new dependency libplds4.so()(64bit) on distro openSUSE Leap 42.3 caused by binary brave
01:00:26 Unexpected new dependency libresolv.so.2()(64bit) on distro Fedora 26 caused by binary brave
01:00:26 Unexpected new dependency libcairo-gobject.so.2()(64bit) on distro Fedora 26 caused by binary brave
01:00:26 Unexpected new dependency libplc4.so()(64bit) on distro Fedora 26 caused by binary brave
01:00:26 Unexpected new dependency libz.so.1()(64bit) on distro Fedora 26 caused by binary brave
01:00:26 Unexpected new dependency libplds4.so()(64bit) on distro Fedora 26 caused by binary brave
01:00:26 Unexpected new dependency libresolv.so.2()(64bit) on distro Fedora 27 caused by binary brave
01:00:26 Unexpected new dependency libcairo-gobject.so.2()(64bit) on distro Fedora 27 caused by binary brave
01:00:26 Unexpected new dependency libplc4.so()(64bit) on distro Fedora 27 caused by binary brave
01:00:26 Unexpected new dependency libz.so.1()(64bit) on distro Fedora 27 caused by binary brave
01:00:26 Unexpected new dependency libplds4.so()(64bit) on distro Fedora 27 caused by binary brave
01:00:26 Unexpected new dependency libresolv.so.2()(64bit) on distro openSUSE Leap 42.2 caused by binary brave
01:00:26 Unexpected new dependency libcairo-gobject.so.2()(64bit) on distro openSUSE Leap 42.2 caused by binary brave
01:00:26 Unexpected new dependency libplc4.so()(64bit) on distro openSUSE Leap 42.2 caused by binary brave
01:00:26 Unexpected new dependency libz.so.1()(64bit) on distro openSUSE Leap 42.2 caused by binary brave
01:00:26 Unexpected new dependency libplds4.so()(64bit) on distro openSUSE Leap 42.2 caused by binary brave
01:00:26 Unexpected new dependency libresolv.so.2()(64bit) on distro Fedora 25 caused by binary brave
01:00:26 Unexpected new dependency libcairo-gobject.so.2()(64bit) on distro Fedora 25 caused by binary brave
01:00:26 Unexpected new dependency libplc4.so()(64bit) on distro Fedora 25 caused by binary brave
01:00:26 Unexpected new dependency libz.so.1()(64bit) on distro Fedora 25 caused by binary brave
01:00:26 Unexpected new dependency libplds4.so()(64bit) on distro Fedora 25 caused by binary brave
01:00:26 [611/644] ACTION //chrome/installer/linux:calculate_deb_dependencies(//build/toolchain/linux:clang_x64)
01:00:29 [612/644] ACTION //chrome/installer/linux:calculate_deb_dependencies(//build/toolchain/linux:clang_x64)
01:00:29 FAILED: deb_brave.deps 
01:00:29 python ../../chrome/installer/linux/debian/calculate_package_deps.py brave ../../build/linux/debian_sid_amd64-sysroot x64 deb_brave.deps --distro-check
01:00:29 Dependency libcairo-gobject2 (>= 1.10.0) not satisfiable on distro Ubuntu 14.04 (Trusty) caused by binary brave
01:00:29 Dependency zlib1g (>= 1:1.1.4) not satisfiable on distro Ubuntu 14.04 (Trusty) caused by binary brave
01:00:29 Dependency libcairo-gobject2 (>= 1.10.0) not satisfiable on distro Debian 9 (Stretch) caused by binary brave
01:00:29 Dependency zlib1g (>= 1:1.1.4) not satisfiable on distro Debian 9 (Stretch) caused by binary brave
01:00:29 Dependency libcairo-gobject2 (>= 1.10.0) not satisfiable on distro Ubuntu 16.04 (Xenial) caused by binary brave
01:00:29 Dependency zlib1g (>= 1:1.1.4) not satisfiable on distro Ubuntu 16.04 (Xenial) caused by binary brave
01:00:29 Dependency libcairo-gobject2 (>= 1.10.0) not satisfiable on distro Debian 10 (Buster) caused by binary brave
01:00:29 Dependency zlib1g (>= 1:1.1.4) not satisfiable on distro Debian 10 (Buster) caused by binary brave
01:00:29 Dependency libcairo-gobject2 (>= 1.10.0) not satisfiable on distro Ubuntu 17.10 (Artful) caused by binary brave
01:00:29 Dependency zlib1g (>= 1:1.1.4) not satisfiable on distro Ubuntu 17.10 (Artful) caused by binary brave
01:00:29 Dependency libcairo-gobject2 (>= 1.10.0) not satisfiable on distro Debian 8 (Jessie) caused by binary brave
01:00:29 Dependency zlib1g (>= 1:1.1.4) not satisfiable on distro Debian 8 (Jessie) caused by binary brave
01:00:34 [613/644] ACTION //brave/app/linux:generate_breakpad_symbols(//build/toolchain/linux:clang_x64)
01:00:34 ninja: build stopped: subcommand failed.
01:00:34 null
01:00:34 null
01:00:34 error Command failed with exit code 1.

Expected result:

Reproduces how often:

Brave version (about:brave info)

Reproducible on current release:

Website problems only:

Does the issue gets fixed with Brave Shields disabled?
Does the issue reproduces on Chrome?

Additional Information

The text was updated successfully, but these errors were encountered:

This is a workaround for the issue described in brave/brave-browser#305

This commit is in reference to brave/brave-browser#305 We still need to run the update script by hand though, to generate a useful json file.

This turns off distro version checks for non-official builds This is in reference to brave#305

Jacalz · 2018-06-07T19:47:22Z

You might want to update https://github.com/brave/brave-browser/wiki/Linux-Development-Environment arter this gets fixed 😉

mbacchi · 2018-06-08T15:55:34Z

I wanted to reference this Chromium issue which is related to this problem, for posterity: https://bugs.chromium.org/p/chromium/issues/detail?id=766710

This turns off distro version checks for non-official builds This is in reference to #305

fmarier · 2019-04-24T14:41:00Z

I ran into the same problems in brave/brave-core#1078 (comment).

The solution, which I documented in https://github.com/brave/brave-browser/wiki/Linux-packages#build-command, is to use --official_build=true or to omit that option entirely.

maximbaz · 2019-06-20T22:27:51Z

Maybe something has changed, but this trick doesn't work for me anymore 😞 I used the --official_build=true (the full command below) and still got all these compilation errors.

npm install
npm run init
npm run create_dist Release --debug_build=false --official_build=true

And the errors are like:

[38185/38211] ACTION //chrome/installer/linux:calculate_rpm_dependencies(//build/toolchain/linux:clang_x64)           
FAILED: rpm_libwidevinecdm.deps                                                                                       
python ../../chrome/installer/linux/rpm/calculate_package_deps.py libwidevinecdm.so rpm_libwidevinecdm.deps libwidevin
ecdm.so --distro-check                                                                                                
Traceback (most recent call last):                                                                                    
  File "../../chrome/installer/linux/rpm/calculate_package_deps.py", line 34, in <module>                             
    stdout=subprocess.PIPE, stderr=subprocess.PIPE)                                                                   
  File "/usr/lib/python2.7/subprocess.py", line 394, in __init__                                                      
    errread, errwrite)                                                                                                
  File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child                                               
    raise child_exception                                                                                             
OSError: [Errno 2] No such file or directory                                                                          
[38186/38211] ACTION //chrome/installer/linux:calculate_deb_dependencies(//build/toolchain/linux:clang_x64)           
FAILED: deb_brave_sandbox.deps                                                                                        
python ../../chrome/installer/linux/debian/calculate_package_deps.py brave_sandbox ../../build/linux/debian_sid_amd64-
sysroot x64 deb_brave_sandbox.deps --distro-check                                                                     
Traceback (most recent call last):                                                                                    
  File "../../chrome/installer/linux/debian/calculate_package_deps.py", line 59, in <module>                          
    cwd=sysroot)                                                                                                      
  File "/usr/lib/python2.7/subprocess.py", line 394, in __init__                                                      
    errread, errwrite)                                                                                                
  File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child                                                   raise child_exception                                                                                             
OSError: [Errno 2] No such file or directory                                                                          
[38187/38211] ACTION //chrome/installer/linux:calculate_deb_dependencies(//build/toolchain/linux:clang_x64)           
FAILED: deb_brave.deps                                                                                                
python ../../chrome/installer/linux/debian/calculate_package_deps.py brave ../../build/linux/debian_sid_amd64-sysroot 
x64 deb_brave.deps --distro-check                                                                                     
Traceback (most recent call last):                                                                                    
  File "../../chrome/installer/linux/debian/calculate_package_deps.py", line 59, in <module>                          
    cwd=sysroot)                                                                                                      
  File "/usr/lib/python2.7/subprocess.py", line 394, in __init__                                                      
    errread, errwrite)                                                                                                
  File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child                                                   raise child_exception                                                                                             
OSError: [Errno 2] No such file or directory

bsclifton · 2019-07-17T22:34:44Z

@maximbaz can you try also passing in --skip_signing? This is going to fail for most people (as-is) because it will try to do signing for the binaries

maximbaz · 2019-07-17T22:41:46Z

I think it fails before signing, due to me not having the necessary tools to create .deb and .rpm files.

But this actually isn't an issue for me anymore - to create an Arch Linux package I ended up using a simple npm run build Release and then cherry-picking the necessary files from /src/out/Release folder.

Here are the full build instructions, by the way, in case anyone is interested: PKGBUILD

fmarier · 2019-07-17T23:24:09Z

@bsclifton Is the original issue (builds not working with --official-build=false) actually fixed or did you close this based on #305 (comment)?

bsclifton · 2019-07-18T18:50:39Z

@fmarier good question... I know I have built with --official-build=false, but I haven't tried to do create_dist. I'll keep open until we can confirm that

This turns off distro version checks for non-official builds This is in reference to brave/brave-browser#305

bkero added a commit to bkero/brave-core that referenced this issue Jun 7, 2018

Disable distro check for linux builds to fix failing builds

248fd14

This is a workaround for the issue described in brave/brave-browser#305

bkero mentioned this issue Jun 7, 2018

Disable distro check for linux builds to fix failing builds brave/brave-core#149

Closed

9 tasks

bkero mentioned this issue Jun 7, 2018

Add packages and libraries to filter list for dep checking on linux brave/brave-core#150

Merged

9 tasks

bkero added a commit to bkero/brave-browser that referenced this issue Jun 7, 2018

add toggle for enable_distro_version_check

8e82d22

This turns off distro version checks for non-official builds This is in reference to brave#305

bkero mentioned this issue Jun 7, 2018

add toggle for enable_distro_version_check #306

Merged

9 tasks

bbondy added this to the Releasable builds milestone Jun 14, 2018

bkero added a commit that referenced this issue Jun 25, 2018

add toggle for enable_distro_version_check

e4b134b

This turns off distro version checks for non-official builds This is in reference to #305

Jacalz added dev-setup OS/Linux labels Jul 9, 2018

bbondy modified the milestones: Releasable builds 0.55.x, Backlog Aug 20, 2018

rebron modified the milestone: 1.x Backlog Feb 7, 2019

fmarier changed the title ~~Build fails checking linux package deps on other distros~~ Build fails checking linux package deps on other distros when --official-build=false Apr 24, 2019

This was referenced Jun 21, 2019

Enable vaapi support #4039

Merged

Provide official support (binaries) for Manjaro and Arch based Linux distro #1950

Open

maximbaz mentioned this issue Jul 7, 2019

Packaging Brave with VA-API for Arch Linux maximbaz/pkgbuild-brave-vaapi#1

Closed

bsclifton closed this as completed Jul 17, 2019

bsclifton reopened this Jul 18, 2019

simonhong assigned simonhong and unassigned simonhong Nov 5, 2019

petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020

add toggle for enable_distro_version_check

1d73fe4

This turns off distro version checks for non-official builds This is in reference to brave/brave-browser#305

petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020

add toggle for enable_distro_version_check

8a54ad8

This turns off distro version checks for non-official builds This is in reference to brave/brave-browser#305

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build fails checking linux package deps on other distros when --official-build=false #305

Build fails checking linux package deps on other distros when --official-build=false #305

bkero commented Jun 7, 2018

Jacalz commented Jun 7, 2018

mbacchi commented Jun 8, 2018

fmarier commented Apr 24, 2019

maximbaz commented Jun 20, 2019

bsclifton commented Jul 17, 2019

maximbaz commented Jul 17, 2019

fmarier commented Jul 17, 2019

bsclifton commented Jul 18, 2019

Build fails checking linux package deps on other distros when --official-build=false #305

Build fails checking linux package deps on other distros when --official-build=false #305

Comments

bkero commented Jun 7, 2018

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (about:brave info)

Reproducible on current release:

Website problems only:

Additional Information

Jacalz commented Jun 7, 2018

mbacchi commented Jun 8, 2018

fmarier commented Apr 24, 2019

maximbaz commented Jun 20, 2019

bsclifton commented Jul 17, 2019

maximbaz commented Jul 17, 2019

fmarier commented Jul 17, 2019

bsclifton commented Jul 18, 2019