Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update design for Brave Rewards onboarding (first time view on opt in) #3123

Closed
mandar-brave opened this issue Jan 28, 2019 · 5 comments · Fixed by brave/brave-core#1574
Closed

Comments

@mandar-brave
Copy link

  • All titles for all panels need to be colored appropriately (based on design provided)
  • Toggles for a-c and Ads Panel need to be turned ON (no toggle for Tips)
  • All Panels should have bolded/colored explainer text (based on design provided)

@jenn-rhim @NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 28, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 5, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 6, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Feb 6, 2019
@btlechowski
Copy link

btlechowski commented Feb 25, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1574

Verification passed on

Brave 0.61.39 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux Mint

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 27, 2019

As per the test plan brave/brave-core#1574. Toggle should be available for a-c and Ads Panel
On Linux - Toggle is not available for Ads, is this because Ads is not yet implemented for Linux platform?

image
@jenn-rhim @NejcZdovc

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya ads are still disabled

@GeetaSarvadnya
Copy link

@NejcZdovc Do you mean Ads are still disabled on Linux platform. Hence the toggle switch is not shown?

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya correct

@rebron rebron changed the title Onboarding page for Brave Rewards (first time view on opt in) update design for Brave Rewards on boarding (first time view on opt in) Mar 5, 2019
@rebron rebron changed the title update design for Brave Rewards on boarding (first time view on opt in) update design for Brave Rewards onboarding (first time view on opt in) Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants