Block autoplay on whitelisted site doesn't work

[srirambv]

Description

Attempting to block autoplay on a site that is whitelisted is quite difficult than it sounds. On YT, changing autoplay to block only blocks on that video and not at domain level. The entry for a domain in brave://settings/content/autoplay doesn't result in blocking autoplay and user still needs to block it on each individual page

Steps to Reproduce

1. Clean profile and visit YT
2. Click site settings and change autoplay to Block
3. Page asks for reload, reload the page and still plays the video
4. Add https://youtube.com:443 entry in brave://settings/content/autoplay under block
5. Open a new tab and load a YT video, still not blocked continues to autoplay
6. Click on the site setting and change auto play setting, page reload triggers block
7. Go back to YT home page and load another video this time autoplay block fails and video continues to autoplay

Actual result:

Watch the full steps here https://youtu.be/rAxzyo4-J_s

Expected result:

Adding a site exception should block autoplay at the domain level even if its added to whitelist

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision	f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS	All

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
  N/A
• Is the issue reproducible on the latest version of Chrome?
  N/A

Additional Information

Issue reported and discussed on https://community.brave.com/t/autoplay-was-blocked-on-this-page-not-actually-blocking-autoplay/33565/8
cc: @bbondy @brave/legacy_qa

[btlechowski]

+1 from https://community.brave.com/t/unable-to-block-autoplay-setting-dont-work/63681

[Brave-Matt]

+1 from reddit:
https://www.reddit.com/r/brave_browser/comments/bw4zgq/autoplay_feature_not_working/

[Brave-Matt]

+1 from Community:
https://community.brave.com/t/not-possible-to-set-youtube-com-autoplay-to-block/63685/3

[Brave-Matt]

+1 from Community:
https://community.brave.com/t/cant-block-autoplay-on-soundcloud/60814/4

[srirambv]

This is still a problem. Unable to set YT to block autoplay since its whitelisted.

cc: @bbondy @rebron this is regressed and needs to be fixed. Please assign a priority for this

[Zoooook]

I'm not familiar with how Brave is architected, but wouldn't a simpler and more transparent solution be to pre-populate the user's Autoplay Allow list at chrome://settings/content/autoplay so that they have access to it, rather than having to code around a hidden whitelist?

[srirambv]

+1 from @triolan1 via #6325

[srirambv]

+1 from @stortzm via #7563

[rebron]

@pilgrim-brave @pes10k Adding youtube to the block list still doesn't seem to block autoplay. Any ideas?

[rebron]

@srirambv This should work now due to #8408

[posita]

+1 from me. I've tested both of these, and they cure the problem:

• Disable HTML5 Autoplay (Reloaded)
• AutoplayStopper

I'm unable to find sources for either of those, however.